Re: [Openvpn-devel] [PATCH] ntlm: Clarify details on NTLM phase 3 decoding

2023-08-02 Thread David Sommerseth
On 02/08/2023 13:31, David Sommerseth wrote: From: David Sommerseth The code was very clear if we accept that the base64 decode of the There is a "not" missing in the line above: "The code was not very clear ..." I'm fine with fixing this at commit time. -- kind regards, David Sommerse

[Openvpn-devel] [PATCH] ntlm: Clarify details on NTLM phase 3 decoding

2023-08-02 Thread David Sommerseth
From: David Sommerseth The code was very clear if we accept that the base64 decode of the NTLM challenge was truncated or not. Move the related code lines closer to where it first used and comment what we are not concerned about any truncation. If the decoded result is truncated, the NTLM serve