Re: [Openvpn-devel] [PATCH] wintun: refactor code to use enum driver type

2020-01-19 Thread Gert Doering
Hi, On Thu, Jan 16, 2020 at 03:19:00PM +0100, Simon Rozman wrote: > { > @@ -3676,14 +3692,16 @@ get_tap_reg(struct gc_arena *gc) > > if (status == ERROR_SUCCESS && data_type == REG_SZ) > { > -if (!strcmp(component_id, TAP_WIN_COMPONENT_ID)

Re: [Openvpn-devel] [PATCH] wintun: refactor code to use enum driver type

2020-01-17 Thread Lev Stipakov
Hi, While we've discussed this during hackathon, it would nevertheless be nice to explain in commit message why this is needed (something like make code more device type agnostic). Also, this line +msg(M_FATAL, "Adapter '%s' is using %s driver, %s expected. If you want to use this

[Openvpn-devel] [PATCH] wintun: refactor code to use enum driver type

2020-01-16 Thread Simon Rozman
Signed-off-by: Simon Rozman --- src/openvpn/forward.c | 4 +- src/openvpn/init.c| 2 +- src/openvpn/options.c | 16 +++ src/openvpn/options.h | 2 +- src/openvpn/tun.c | 108 -- src/openvpn/tun.h | 16 +-- 6 files changed, 75