Re: [Openvpn-devel] [PATCH] wintun: upgrade error message in case of ring registration failure

2020-03-10 Thread Lev Stipakov
Sorry, my bad - this is correct. Compiled, tested with MSVC, Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] wintun: upgrade error message in case of ring registration failure

2020-03-09 Thread Simon Rozman
To: Simon Rozman Cc: openvpn-devel Subject: Re: [Openvpn-devel] [PATCH] wintun: upgrade error message in case of ring registration failure Hi, -msg(M_NONFATAL, "Failed to register ring buffers: %lu", GetLastError()); +switch (Ge

Re: [Openvpn-devel] [PATCH] wintun: upgrade error message in case of ring registration failure

2020-02-05 Thread Lev Stipakov
Hi, -msg(M_NONFATAL, "Failed to register ring buffers: %lu", > GetLastError()); > > +switch (GetLastError()) > > +default: > +msg(M_NONFATAL | M_ERRNO, "Failed to register ring > buffers"); > I think it would make sense to print the

[Openvpn-devel] [PATCH] wintun: upgrade error message in case of ring registration failure

2020-02-05 Thread Simon Rozman
Rather than have the Interactive Service return a custom 0x2004 (ERROR_REGISTER_RING_BUFFERS) error, return the true GetLastError() code that the TUN_IOCTL_REGISTER_RINGS provides. Signed-off-by: Simon Rozman --- src/openvpn/ring_buffer.h | 2 +- src/openvpn/tun.c | 18