Re: [Openvpn-devel] [PATCH 1/5] MSVC: Disable LZ4

2021-03-22 Thread Lev Stipakov
For 2.6, I think we should drop openvpn-build for Windows (VS) building and switch to vcpkg for dependencies (openssl, lz4 etc) and cmake as a project file (also supported by VS). -- -Lev ___ Openvpn-devel mailing list

Re: [Openvpn-devel] [PATCH 1/5] MSVC: Disable LZ4

2021-03-22 Thread Gert Doering
Hi, On Mon, Mar 22, 2021 at 07:29:30AM +, Simon Rozman wrote: > Thank you and Arne for explaining this. I should have followed > the discussion on the OpenVPN meetings. Unfortunately, my workload > doesn't allow me to follow on anything these days. So, I am not in > condition to prepare LZ4

Re: [Openvpn-devel] [PATCH 1/5] MSVC: Disable LZ4

2021-03-22 Thread Simon Rozman via Openvpn-devel
Hi, > > Commit 24596b25 ("build: Remove compat-lz4") removed lz4 compat layer, > > but openvpn-build\msvc doesn't provide LZ4 library either. > > What would be needed to actually *build* with LZ4 on MSVC? That is, > build it as prerequisite as LZO is built? > > The idea wasn't to remove LZ4

Re: [Openvpn-devel] [PATCH 1/5] MSVC: Disable LZ4

2021-03-21 Thread Gert Doering
Hi, On Sun, Mar 21, 2021 at 03:46:23PM +0100, Simon Rozman via Openvpn-devel wrote: > Commit 24596b25 ("build: Remove compat-lz4") removed lz4 compat layer, > but openvpn-build\msvc doesn't provide LZ4 library either. What would be needed to actually *build* with LZ4 on MSVC? That is, build it

Re: [Openvpn-devel] [PATCH 1/5] MSVC: Disable LZ4

2021-03-21 Thread Arne Schwabe
Am 21.03.21 um 15:46 schrieb Simon Rozman via Openvpn-devel: > Commit 24596b25 ("build: Remove compat-lz4") removed lz4 compat layer, > but openvpn-build\msvc doesn't provide LZ4 library either. We should either add lz4 to openvpn-build or change the default of lz4 to disabled in all variant. I

[Openvpn-devel] [PATCH 1/5] MSVC: Disable LZ4

2021-03-21 Thread Simon Rozman via Openvpn-devel
Commit 24596b25 ("build: Remove compat-lz4") removed lz4 compat layer, but openvpn-build\msvc doesn't provide LZ4 library either. Signed-off-by: Simon Rozman --- config-msvc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/config-msvc.h b/config-msvc.h index e430ca96..53d97902 100644 ---