Re: [Openvpn-devel] [PATCH 2/2] signal_reset(): combine check and reset operations

2023-07-26 Thread Frank Lichtenheld
On Tue, Jul 25, 2023 at 01:42:41PM -0400, Selva Nair wrote: > On Tue, Jul 25, 2023 at 6:18 AM Frank Lichtenheld > wrote: > > > On Sat, Jan 28, 2023 at 04:59:01PM -0500, selva.n...@gmail.com wrote: > > > From: Selva Nair > > > > > > - "if (sig == X) signal_reset(sig)" now becomes > > >

Re: [Openvpn-devel] [PATCH 2/2] signal_reset(): combine check and reset operations

2023-07-25 Thread Selva Nair
On Tue, Jul 25, 2023 at 6:18 AM Frank Lichtenheld wrote: > On Sat, Jan 28, 2023 at 04:59:01PM -0500, selva.n...@gmail.com wrote: > > From: Selva Nair > > > > - "if (sig == X) signal_reset(sig)" now becomes > > "signal_reset(sig, X)" so that the check and assignment > > can be done in one

Re: [Openvpn-devel] [PATCH 2/2] signal_reset(): combine check and reset operations

2023-07-25 Thread Frank Lichtenheld
On Sat, Jan 28, 2023 at 04:59:01PM -0500, selva.n...@gmail.com wrote: > From: Selva Nair > > - "if (sig == X) signal_reset(sig)" now becomes > "signal_reset(sig, X)" so that the check and assignment > can be done in one place where signals are masked. > This is required to avoid change of

[Openvpn-devel] [PATCH 2/2] signal_reset(): combine check and reset operations

2023-01-28 Thread selva . nair
From: Selva Nair - "if (sig == X) signal_reset(sig)" now becomes "signal_reset(sig, X)" so that the check and assignment can be done in one place where signals are masked. This is required to avoid change of signal state between check and reset operations. - Avoid resetting the signal