Re: [Openvpn-devel] [PATCH 2/3] auth.c: make cast explicit in the crypto API

2019-11-10 Thread Arne Schwabe
Am 10.11.19 um 14:35 schrieb Antonio Quartulli: > mbedtls_md_get_size() returns unsigned char, while EVP_MD_size() returns > int. Results coming from both functions are normally in a uint8_t member > of the key_type struct, because it is known that 8bits are enough (also > for EVP_MD_size()). > >

[Openvpn-devel] [PATCH 2/3] auth.c: make cast explicit in the crypto API

2019-11-10 Thread Antonio Quartulli
mbedtls_md_get_size() returns unsigned char, while EVP_MD_size() returns int. Results coming from both functions are normally in a uint8_t member of the key_type struct, because it is known that 8bits are enough (also for EVP_MD_size()). This unexpected cast can, however, trigger unsolicited warni