Re: [Openvpn-devel] [PATCH 3/4] cleanup: avoid using ~0 - netmask

2012-04-02 Thread David Sommerseth
On 29/03/12 11:16, Alon Bar-Lev wrote: > Use IPV4_NETMASK_HOST constant. > > Signed-off-by: Alon Bar-Lev > --- > src/openvpn/basic.h |2 ++ > src/openvpn/mroute.c |2 +- > src/openvpn/pf.c |2 +- > src/openvpn/route.c | 12 ++-- > src/openvpn/route.h |2 +- > src

Re: [Openvpn-devel] [PATCH 3/4] cleanup: avoid using ~0 - netmask

2012-03-31 Thread Gert Doering
Hi, On Thu, Mar 29, 2012 at 11:16:41AM +0200, Alon Bar-Lev wrote: > Use IPV4_NETMASK_HOST constant. > > Signed-off-by: Alon Bar-Lev ACK on this one, to start with. Thanks. The others I'm just looking into, but need to read a bit more code around to see whether I fully understand what that cod

[Openvpn-devel] [PATCH 3/4] cleanup: avoid using ~0 - netmask

2012-03-29 Thread Alon Bar-Lev
Use IPV4_NETMASK_HOST constant. Signed-off-by: Alon Bar-Lev --- src/openvpn/basic.h |2 ++ src/openvpn/mroute.c |2 +- src/openvpn/pf.c |2 +- src/openvpn/route.c | 12 ++-- src/openvpn/route.h |2 +- src/openvpn/tun.c|2 +- 6 files changed, 12 insertions