Re: [Openvpn-devel] [PATCH 4/7] wintun: register ring buffers when iterating adapters

2019-12-20 Thread Lev Stipakov
Hi, Compiled and tested, works as expected. One thing: > +if (tun_try_open_device(tt, *device_guid, > device_instance_id_interface)) > { > break; > } > We leak tt->hand here if we don't break - in the next loop iteration we overwrite tt->ha

[Openvpn-devel] [PATCH 4/7] wintun: register ring buffers when iterating adapters

2019-12-19 Thread Simon Rozman
Wintun adapters may be considered available if ring buffer registration succeeded. Therefore, we must attempt to register ring buffers when iterating adapters and continue on failure. Signed-off-by: Simon Rozman --- src/openvpn/tun.c | 110 +++--- 1 file c