Re: [Openvpn-devel] [PATCH applied] Re: OpenSSL: don't use direct access to the internal of RSA_METHOD

Hi, On Sun, Mar 05, 2017 at 01:08:09PM +0100, Emmanuel Deloget wrote: > I don't like it much either but I cannot think of a better solution. I haven't said that I don't *like* it :-) - I came across it when doing a "post commit sanity check" and assumed that there are good reasons. Just

Re: [Openvpn-devel] [PATCH applied] Re: OpenSSL: don't use direct access to the internal of RSA_METHOD

Hi, On Sun, Mar 5, 2017 at 11:29 AM, Steffan Karger wrote: > > On 05-03-17 10:53, Gert Doering wrote: >> Small side note: I assume that RSA_meth_new() can fail and return NULL >> in OpenSSL 1.1? Because for 1.0, the "check_malloc_return(rsa_meth)" call >> isn't necessary, as

Re: [Openvpn-devel] [PATCH applied] Re: OpenSSL: don't use direct access to the internal of RSA_METHOD

On 05-03-17 10:53, Gert Doering wrote: > Small side note: I assume that RSA_meth_new() can fail and return NULL > in OpenSSL 1.1? Because for 1.0, the "check_malloc_return(rsa_meth)" call > isn't necessary, as ALLOC_OBJ_CLEAR() would call ALLOC_OBJ() and that > already checks... (mentioning

[Openvpn-devel] [PATCH applied] Re: OpenSSL: don't use direct access to the internal of RSA_METHOD

Your patch (v3) has been applied to the master and release/2.4 branch. Small side note: I assume that RSA_meth_new() can fail and return NULL in OpenSSL 1.1? Because for 1.0, the "check_malloc_return(rsa_meth)" call isn't necessary, as ALLOC_OBJ_CLEAR() would call ALLOC_OBJ() and that already