Stared a bit at the difference of v2 and v5 (windows pipe cast plus
clang pragma). All the rest is identical to v2, and trivial in itself
("git show -w -I snprintf").
Self test passes, and compilation / GHA also passes.
I have adapted the "We know that the results truncated" comment
(added "will be") - I think that was in v2 already, or in Antonio's
comment on v2, but it's a comment, so no good in asking for a v6.
Your patch has been applied to the master branch.
commit 130548fe4d23afac5d2948d4e5ee164eef635cfd
Author: Arne Schwabe
Date: Mon May 6 12:27:10 2024 +0200
Remove openvpn_snprintf and similar functions
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Acked-by: Frank Lichtenheld <fr...@lichtenheld.com>
Message-Id: <20240506102710.8976-1-g...@greenie.muc.de>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28617.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
