Re: [Openvpn-devel] [PATCH v2] BUILD: enable CFG and Spectre mitigation for MSVC

2021-11-24 Thread Gert Doering
Hi, On Wed, Nov 24, 2021 at 04:21:38PM +0200, Lev Stipakov wrote: > Since we're preparing the next 2.5 release, let's take this in. The > performance numbers, reported in different thread, look good. Yes, sir! commit dab73f90983c929645c74f1c1c045e175d5ca2b6 (HEAD -> release/2.5) Author: Ilya Shi

Re: [Openvpn-devel] [PATCH v2] BUILD: enable CFG and Spectre mitigation for MSVC

2021-11-24 Thread Илья Шипицин
Performance report was delayed due to oversize. It was only delivered to Lev and Gert. Thank you Lev for bringing this up:) Performance was captured by WPT. I'd like to make some similar investigation if needed (to compare other perf impact) On Wed, Nov 24, 2021, 7:21 PM Lev Stipakov wrote: >

Re: [Openvpn-devel] [PATCH v2] BUILD: enable CFG and Spectre mitigation for MSVC

2021-11-24 Thread Lev Stipakov
Since we're preparing the next 2.5 release, let's take this in. The performance numbers, reported in different thread, look good. ma 27. syysk. 2021 klo 13.06 Илья Шипицин (chipits...@gmail.com) kirjoitti: > > I'll setup test stand similar to this one > https://community.openvpn.net/openvpn/wiki/

Re: [Openvpn-devel] [PATCH v2] BUILD: enable CFG and Spectre mitigation for MSVC

2021-09-27 Thread Илья Шипицин
I'll setup test stand similar to this one https://community.openvpn.net/openvpn/wiki/PerformanceTestingOpenVPN hopefully in next 1-2 weeks I also believe that spectre mitigation is neglectable, but it is good to have numbers пн, 27 сент. 2021 г. в 12:58, Lev Stipakov : > I didn't, but here > > h

Re: [Openvpn-devel] [PATCH v2] BUILD: enable CFG and Spectre mitigation for MSVC

2021-09-27 Thread Lev Stipakov
I didn't, but here https://devblogs.microsoft.com/cppblog/spectre-mitigations-in-msvc/ it says that "On the MSVC team, we’ve reviewed information in detail and conducted extensive tests, which showed the performance impact of the new /Qspectre switch to be negligible." -- -Lev ___

Re: [Openvpn-devel] [PATCH v2] BUILD: enable CFG and Spectre mitigation for MSVC

2021-09-24 Thread Arne Schwabe
Am 22.09.21 um 11:57 schrieb Ilya Shipitsin: > found by BinSkim > Did you do a performance comparison? IN the past some of the Spectre mitigations have had really hard performance impact. Arne ___ Openvpn-devel mailing list Openvpn-devel@lists.sourcef

Re: [Openvpn-devel] [PATCH v2] BUILD: enable CFG and Spectre mitigation for MSVC

2021-09-23 Thread Lev Stipakov
Built and smoke-tested locally. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH v2] BUILD: enable CFG and Spectre mitigation for MSVC

2021-09-22 Thread Ilya Shipitsin
found by BinSkim Signed-off-by: Ilya Shipitsin --- src/compat/Release.props| 1 + src/compat/compat.vcxproj | 6 ++ src/openvpn/openvpn.vcxproj | 9 + src/openvpnmsica/openvpnmsica-Release.props | 1 + src/openvpnmsica/openvpnmsic