Re: [Openvpn-devel] [PATCH v2] Load OpenSSL config on Windows from trusted location

2021-11-23 Thread Lev Stipakov
Hi, > Does this string concatenation like L"foo" "bar" work correctly on MSVC? I > know it works on mingw, but in the past with the GUI resources we had run > into issues with such usage -- iirc, MSVC wanted L"foo" L"bar". I think so, at least result of concatenation looks correct in procmon:

Re: [Openvpn-devel] [PATCH v2] Load OpenSSL config on Windows from trusted location

2021-11-23 Thread Selva Nair
Hi, +1 for setting these env vars. I will test this but some quick comments On Tue, Nov 23, 2021 at 10:08 AM Lev Stipakov wrote: > From: Lev Stipakov > > Commit 7e33127d5 ("contrib/vcpkg-ports: remove openssl port") > disabled OpenSSL config loading to prevent loading config > from untrusted

[Openvpn-devel] [PATCH v2] Load OpenSSL config on Windows from trusted location

2021-11-23 Thread Lev Stipakov
From: Lev Stipakov Commit 7e33127d5 ("contrib/vcpkg-ports: remove openssl port") disabled OpenSSL config loading to prevent loading config from untrusted locations. Config loading feature might be useful for some users. This brings it back, and sets OpenSSL enviroment variables OPENSSL_CONF,