Re: [Openvpn-devel] [PATCH v2] msvc: always call git-version.py

2022-11-11 Thread Lev Stipakov
Don't know if I can ack the patch to which I've contributed - but anyway, the makefile change looks good and the python script doesn't regenerate version header (which would trigger recompilation of some files). Tested locally and GHA is happy. Acked-by: Lev Stipakov __

[Openvpn-devel] [PATCH v2] msvc: always call git-version.py

2022-11-11 Thread Frank Lichtenheld
There is no way to detect whether this information is outdated in nmake itself. So leave it up to the Python script to decide. While here, change some leading whitespace to tabs as expected in Makefile. Signed-off-by: Frank Lichtenheld Signed-off-by: Lev Stipakov --- build/msvc/msvc-generate/M