Re: [Openvpn-devel] [PATCH v2] tun: remove tun_finalize()

2022-01-15 Thread Selva Nair
Hi, On Sat, Jan 15, 2022 at 3:25 AM Antonio Quartulli wrote: > > Hi Selva, > > we were hoping to hear your opinion on this :-) > > We spent quite some time figuring out if we have to use both the non-WSA > and the WSA variant of the API in our code, and it seems we have to. > > (not because

Re: [Openvpn-devel] [PATCH v2] tun: remove tun_finalize()

2022-01-15 Thread Antonio Quartulli
Hi Selva, we were hoping to hear your opinion on this :-) We spent quite some time figuring out if we have to use both the non-WSA and the WSA variant of the API in our code, and it seems we have to. (not because using one variant only would not work, but rather because the spec demands

[Openvpn-devel] [PATCH v2] tun: remove tun_finalize()

2022-01-14 Thread Lev Stipakov
From: Lev Stipakov tun_finalize() is essentially subset of socket_finalize() apart from: - using WSAFoo() functions instead of Foo() - "from" address is not returned There is no clear official statement that one can use non-WSA API on handles, so let's be on a safe side and use both.