Re: [Openvpn-devel] [PATCH v2 2/2] List ChaCha20-Poly1305 as stream cipher

2018-10-08 Thread Antonio Quartulli
Hi, see below: On 08/10/18 06:30, Steffan Karger wrote: [CUT] > diff --git a/src/openvpn/crypto_mbedtls.c b/src/openvpn/crypto_mbedtls.c > index 0c39eccc..54ac1893 100644 > --- a/src/openvpn/crypto_mbedtls.c > +++ b/src/openvpn/crypto_mbedtls.c > @@ -140,26 +140,6 @@ const cipher_name_pair cipher

[Openvpn-devel] [PATCH v2 2/2] List ChaCha20-Poly1305 as stream cipher

2018-10-07 Thread Steffan Karger
As Antonio pointed out, "8-bit block cipher" is a bit funny. So teach print_cipher() to print such cipher as "stream cipher". Because I didn't want to write the same code twice, I decided to merge the two print_cipher() implementations into one shared function. That should make it easier to keep b