Re: [Openvpn-devel] [PATCH v2 5/9] Remove key-method 1

2020-07-20 Thread David Sommerseth
On 20/07/2020 15:22, Arne Schwabe wrote: > Am 20.07.20 um 15:16 schrieb David Sommerseth: >> On 17/07/2020 15:47, Arne Schwabe wrote: >>> Key-method 1 is only needed to talk to pre OpenVPN 2.0 clients. >>> >>> Patch V2: Fix style. Make V1 op codes illegal, remove all code handling >>> v1

Re: [Openvpn-devel] [PATCH v2 5/9] Remove key-method 1

2020-07-20 Thread Arne Schwabe
Am 20.07.20 um 15:16 schrieb David Sommerseth: > On 17/07/2020 15:47, Arne Schwabe wrote: >> Key-method 1 is only needed to talk to pre OpenVPN 2.0 clients. >> >> Patch V2: Fix style. Make V1 op codes illegal, remove all code handling >> v1 op codes and give a good warning message if we e

Re: [Openvpn-devel] [PATCH v2 5/9] Remove key-method 1

2020-07-20 Thread David Sommerseth
On 17/07/2020 15:47, Arne Schwabe wrote: > Key-method 1 is only needed to talk to pre OpenVPN 2.0 clients. > > Patch V2: Fix style. Make V1 op codes illegal, remove all code handling > v1 op codes and give a good warning message if we encounter > them in the legal op codes pre-

[Openvpn-devel] [PATCH v2 5/9] Remove key-method 1

2020-07-17 Thread Arne Schwabe
Key-method 1 is only needed to talk to pre OpenVPN 2.0 clients. Patch V2: Fix style. Make V1 op codes illegal, remove all code handling v1 op codes and give a good warning message if we encounter them in the legal op codes pre-check. Signed-off-by: Arne Schwabe --- doc/doxyg