Re: [Openvpn-devel] [PATCH v3] tun: remove tun_finalize()

2022-01-20 Thread Selva Nair
Hi, On Mon, Jan 17, 2022 at 4:51 AM Lev Stipakov wrote: > From: Lev Stipakov > > tun_finalize() is essentially subset of socket_finalize() apart from: > > - using WSAFoo() functions instead of Foo() > > - "from" address is not returned > > There is no clear official statement that one can

Re: [Openvpn-devel] [PATCH v3] tun: remove tun_finalize()

2022-01-19 Thread Lev Stipakov
Gentle nudge. ma 17. tammik. 2022 klo 13.42 Gert Doering (g...@greenie.muc.de) kirjoitti: > > Hi, > > On Mon, Jan 17, 2022 at 11:56:51AM +0200, Lev Stipakov wrote: > > This is probably something committer (looks at cron2) could fix on the > > fly, unless there are more issues which would require

Re: [Openvpn-devel] [PATCH v3] tun: remove tun_finalize()

2022-01-17 Thread Gert Doering
Hi, On Mon, Jan 17, 2022 at 11:56:51AM +0200, Lev Stipakov wrote: > This is probably something committer (looks at cron2) could fix on the > fly, unless there are more issues which would require v4? If that's the only thing, I can fix that on the fly. gert -- "If was one thing all people took

Re: [Openvpn-devel] [PATCH v3] tun: remove tun_finalize()

2022-01-17 Thread Lev Stipakov
This is probably something committer (looks at cron2) could fix on the fly, unless there are more issues which would require v4? ma 17. tammik. 2022 klo 11.53 Antonio Quartulli (a...@unstable.cc) kirjoitti: > > Hi, > > On 17/01/2022 10:49, Lev Stipakov wrote: > [cut] > > - > > -static inline int

Re: [Openvpn-devel] [PATCH v3] tun: remove tun_finalize()

2022-01-17 Thread Antonio Quartulli
Hi, On 17/01/2022 10:49, Lev Stipakov wrote: [cut] - -static inline int -read_tun_buffered(struct tuntap *tt, struct buffer *buf) -{ -return tun_finalize(tt->hand, >reads, buf); -} +int +tun_write_win32(struct tuntap *tt, struct buffer *buf); for prototypes we put the return type on the

[Openvpn-devel] [PATCH v3] tun: remove tun_finalize()

2022-01-17 Thread Lev Stipakov
From: Lev Stipakov tun_finalize() is essentially subset of socket_finalize() apart from: - using WSAFoo() functions instead of Foo() - "from" address is not returned There is no clear official statement that one can use non-WSA API on handles, so let's be on a safe side and use both.