Re: [Openvpn-devel] [PATCH v3 1/2] OpenSSL: remove some EVP_PKEY type checks

Hello, and sorry for the delay (things like 'real life', you know). On Sat, Jan 20, 2018 at 3:22 PM, Selva Nair wrote: > Hi, > > On Sat, Jan 20, 2018 at 6:30 AM, Steffan Karger wrote: > > Hi, > > > > On 17-01-18 14:10, Emmanuel Deloget wrote: > >>

Re: [Openvpn-devel] [PATCH v3 1/2] OpenSSL: remove some EVP_PKEY type checks

Hi, On Sat, Jan 20, 2018 at 6:30 AM, Steffan Karger wrote: > Hi, > > On 17-01-18 14:10, Emmanuel Deloget wrote: >> Calling EVP_KEY_id() before EVP_PKEY_get0_*() is unnecessary as >> the same check is also performed in the later. >> >> We also make the code a bit better by not

Re: [Openvpn-devel] [PATCH v3 1/2] OpenSSL: remove some EVP_PKEY type checks

Hi, On 17-01-18 14:10, Emmanuel Deloget wrote: > Calling EVP_KEY_id() before EVP_PKEY_get0_*() is unnecessary as > the same check is also performed in the later. > > We also make the code a bit better by not calling the various > EVP_PKEY_get0_*() functions twice (this needs a bit or reordering