Re: [Openvpn-devel] [PATCH v3 17/18] xkey-provider: Add a test for generic key load and signature

2022-01-20 Thread Gert Doering
Hi, On Thu, Jan 20, 2022 at 10:21:19AM -0500, Selva Nair wrote: > Yeah, a previous version had checking for OpenSSL version in configure.ac > and the AM_CONDITIONAL made sense only in that case. I can send a > new 16/18 or please do squash 16 with 17. If you could send a new "16+17 v4" that

Re: [Openvpn-devel] [PATCH v3 17/18] xkey-provider: Add a test for generic key load and signature

2022-01-20 Thread Selva Nair
Hi On Thu, Jan 20, 2022 at 9:51 AM Gert Doering wrote: > Hi, > > On Tue, Dec 14, 2021 at 11:59:27AM -0500, selva.n...@gmail.com wrote: > > From: Selva Nair > > > > Signed-off-by: Selva Nair > > Is it OK if I squash 16+17 together? I dislike the "history churn" > of modifying configure.ac and

Re: [Openvpn-devel] [PATCH v3 17/18] xkey-provider: Add a test for generic key load and signature

2022-01-20 Thread Gert Doering
Hi, On Tue, Dec 14, 2021 at 11:59:27AM -0500, selva.n...@gmail.com wrote: > From: Selva Nair > > Signed-off-by: Selva Nair Is it OK if I squash 16+17 together? I dislike the "history churn" of modifying configure.ac and Makefile.am in 16 just to remove the AM_CONDITIONAL bits again in 17...

Re: [Openvpn-devel] [PATCH v3 17/18] xkey-provider: Add a test for generic key load and signature

2022-01-20 Thread Arne Schwabe
Am 14.12.21 um 17:59 schrieb selva.n...@gmail.com: From: Selva Nair Signed-off-by: Selva Nair --- configure.ac | 2 - tests/unit_tests/openvpn/Makefile.am | 4 - tests/unit_tests/openvpn/test_provider.c | 112 +-- 3 files changed,

[Openvpn-devel] [PATCH v3 17/18] xkey-provider: Add a test for generic key load and signature

2021-12-14 Thread selva . nair
From: Selva Nair Signed-off-by: Selva Nair --- configure.ac | 2 - tests/unit_tests/openvpn/Makefile.am | 4 - tests/unit_tests/openvpn/test_provider.c | 112 +-- 3 files changed, 105 insertions(+), 13 deletions(-) diff --git