Re: [Openvpn-devel] [PATCH v3 7/9] Remove cipher_kt_t and change type to const char* in API

2021-12-10 Thread Selva Nair
Hi, On Fri, Dec 10, 2021 at 8:09 AM Arne Schwabe wrote: > > Make the external crypto consumer oblivious to the internal cipher > type that both mbed TLS and OpenSSL use. This change is mainly done > so the cipher type that is used can be stay a const type but instead > of an SSL library type, we

Re: [Openvpn-devel] [PATCH v3 7/9] Remove cipher_kt_t and change type to const char* in API

2021-12-10 Thread Selva Nair
On Fri, Dec 10, 2021 at 10:09 AM Gert Doering wrote: > > Hi, > > On Fri, Dec 10, 2021 at 02:06:51PM +0100, Arne Schwabe wrote: > > Patch v3: fix errors with mbed TLS without having md_kt to const char * > > patch > > also applied, fix logic inversion in tls_crypt_tk > > Thanks, this is

Re: [Openvpn-devel] [PATCH v3 7/9] Remove cipher_kt_t and change type to const char* in API

2021-12-10 Thread Gert Doering
Hi, On Fri, Dec 10, 2021 at 02:06:51PM +0100, Arne Schwabe wrote: > Patch v3: fix errors with mbed TLS without having md_kt to const char * patch > also applied, fix logic inversion in tls_crypt_tk Thanks, this is much better than v2 - now all client-side tests pass that led to

[Openvpn-devel] [PATCH v3 7/9] Remove cipher_kt_t and change type to const char* in API

2021-12-10 Thread Arne Schwabe
Make the external crypto consumer oblivious to the internal cipher type that both mbed TLS and OpenSSL use. This change is mainly done so the cipher type that is used can be stay a const type but instead of an SSL library type, we now use a simple string to identify a cipher. This has the