Re: [Openvpn-devel] [PATCH v4] Refactor early initialisation and uninitialisation into methods

2021-11-05 Thread Selva Nair
Hi On Fri, Nov 5, 2021 at 12:14 PM Arne Schwabe wrote: > This put the early initialisation and uninitialisation that needs to > happen between option parsing and post processing into small methods. > > Signed-off-by: Arne Schwabe > --- > src/openvpn/openvpn.c | 23 ++- > 1

Re: [Openvpn-devel] [PATCH v4] Refactor early initialisation and uninitialisation into methods

2021-11-05 Thread Antonio Quartulli
Hi, On 05/11/2021 17:20, Gert Doering wrote: Hi, On Fri, Nov 05, 2021 at 05:13:02PM +0100, Arne Schwabe wrote: +static void uninit_early(struct context *c) +{ +net_ctx_free(>net_ctx); +} The extra "&" here does not look right. Shouldn't this be "c->net_ctx" as in "init_early()"? it's

Re: [Openvpn-devel] [PATCH v4] Refactor early initialisation and uninitialisation into methods

2021-11-05 Thread Gert Doering
Hi, On Fri, Nov 05, 2021 at 05:13:02PM +0100, Arne Schwabe wrote: > +static void uninit_early(struct context *c) > +{ > +net_ctx_free(>net_ctx); > +} The extra "&" here does not look right. Shouldn't this be "c->net_ctx" as in "init_early()"? gert -- "If was one thing all people took for

[Openvpn-devel] [PATCH v4] Refactor early initialisation and uninitialisation into methods

2021-11-05 Thread Arne Schwabe
This put the early initialisation and uninitialisation that needs to happen between option parsing and post processing into small methods. Signed-off-by: Arne Schwabe --- src/openvpn/openvpn.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git