Re: [Openvpn-devel] [PATCH v4 3/3] Implement tls-groups option to specify eliptic curves/groups

2020-06-25 Thread Antonio Quartulli
Hi, on my GitLab CI build test, the compilation failed with the following message, while compiling against openssl-1.1: /usr/bin/ld: ssl_openssl.o: in function `tls_ctx_set_tls_groups': /builds/ordex986/openvpn/src/openvpn/ssl_openssl.c:611: undefined reference to `SSL_CTX_set1_groups'

Re: [Openvpn-devel] [PATCH v4 3/3] Implement tls-groups option to specify eliptic curves/groups

2020-06-23 Thread Antonio Quartulli
Hi, On 22/06/2020 16:02, Arne Schwabe wrote: [CUT] > @@ -343,6 +348,42 @@ tls_ctx_set_cert_profile(struct tls_root_ctx *ctx, const > char *profile) > } > } > > +void > +tls_ctx_set_tls_groups(struct tls_root_ctx *ctx, const char *groups) > +{ > +ASSERT(ctx); > +struct gc_arena

[Openvpn-devel] [PATCH v4 3/3] Implement tls-groups option to specify eliptic curves/groups

2020-06-22 Thread Arne Schwabe
By default OpenSSL 1.1+ only allows signatures and ecdh/ecdhx from the default list of X25519:secp256r1:X448:secp521r1:secp384r1. In TLS1.3 key exchange is independent from the signature/key of the certificates, so allowing all groups per default is not a sensible choice anymore and instead a