Re: [Openvpn-devel] [PATCH v6] openvpnserv: enable interactive service to open tun

2019-08-07 Thread Gert Doering
Hi, On Wed, Aug 07, 2019 at 02:12:01PM +0300, Lev Stipakov wrote: > So instead of having IPC call "open_tun_device(path)" it is probably better > to have something like "open_wintun_device()", which both figures out > device path > and opens device. That sounds like a plan. Have one API call

Re: [Openvpn-devel] [PATCH v6] openvpnserv: enable interactive service to open tun

2019-08-07 Thread Lev Stipakov
Let's not merge it yet. The reason why this patch was done is to prepare for Wintun support, since Wintun device must be opened by privileged process. There is no need to use privileged process to open tap-windows6 device. Recently Wintun API has been changed and previous Wintun device path

Re: [Openvpn-devel] [PATCH v6] openvpnserv: enable interactive service to open tun

2019-07-24 Thread Selva Nair
Hi, Looks good now and works as expected. On Tue, Jul 23, 2019 at 5:22 AM Lev Stipakov wrote: > > From: Lev Stipakov > > This patch enables interactive service to open tun device. > This is mostly needed by Wintun, which could be opened > only by privileged process. > > When interactive

Re: [Openvpn-devel] [PATCH v6] openvpnserv: enable interactive service to open tun

2019-07-23 Thread Lev Stipakov
This could be fixed by @cron2 when he will apply this patch :) ti 23. heinäk. 2019 klo 15.12 tincanteksup (tincantek...@gmail.com) kirjoitti: > Looks like a typo below: > > On 23/07/2019 10:21, Lev Stipakov wrote: > > From: Lev Stipakov > > > > This patch enables interactive service to open tun

Re: [Openvpn-devel] [PATCH v6] openvpnserv: enable interactive service to open tun

2019-07-23 Thread tincanteksup
Looks like a typo below: On 23/07/2019 10:21, Lev Stipakov wrote: From: Lev Stipakov This patch enables interactive service to open tun device. This is mostly needed by Wintun, which could be opened only by privileged process. When interactive service is used, instead of calling CreateFile()

[Openvpn-devel] [PATCH v6] openvpnserv: enable interactive service to open tun

2019-07-23 Thread Lev Stipakov
From: Lev Stipakov This patch enables interactive service to open tun device. This is mostly needed by Wintun, which could be opened only by privileged process. When interactive service is used, instead of calling CreateFile() directly by openvpn process we pass tun device path into service