Re: [Openvpn-devel] [PULL-REQUEST v3] VLAN-Tagging

2010-04-28 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thank you Peter, for going so thoroughly through these patches! More comments below ... On 28/04/10 01:07, Peter Stuge wrote: > Fabian Knittel wrote: [...snip...] >> @@ -2033,10 +2062,27 @@ multi_process_incoming_link (struct multi_context >> *m,

Re: [Openvpn-devel] [PULL-REQUEST v3] VLAN-Tagging

2010-04-28 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/04/10 10:22, Fabian Knittel wrote: > Hi David, > > David Sommerseth wrote: >> I've finally found some time to dig into this again. After some >> consideration, I decided to rebase your work on your feat_vlan_tagging >> branch against the

Re: [Openvpn-devel] [PULL-REQUEST v3] VLAN-Tagging

2010-04-28 Thread Fabian Knittel
Hi David, David Sommerseth wrote: > I've finally found some time to dig into this again. After some > consideration, I decided to rebase your work on your feat_vlan_tagging > branch against the openvpn-testing.git feat_vlan_tagging branch. > > This means that your earlier patches without

Re: [Openvpn-devel] [PULL-REQUEST v3] VLAN-Tagging

2010-04-28 Thread Peter Stuge
Fabian Knittel wrote: > I've attached a diff containing all changes introduced by the > current patch-set. Thanks for doing this. It makes review so much easier. > +++ b/configure.ac > @@ -212,6 +212,12 @@ AC_ARG_ENABLE(selinux, > [SELINUX="yes"] > ) > > +AC_ARG_ENABLE(vlan-tagging, > +

Re: [Openvpn-devel] [PULL-REQUEST v3] VLAN-Tagging

2010-04-27 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/04/10 16:39, Fabian Knittel wrote: > Hi, > > changes since the last round of patches: > > - Added Signed-Off-By to all patches. > > - Properly mentioned "--vlan-accept all" mode in options.c (it was >missing in a few places). > > -