Re: [Openvpn-devel] [PATCH] Add TFTP and WPAD DHCP options

2015-07-03 Thread David Sommerseth
On 03/07/15 09:30, Samuli Seppänen wrote: > >> Attached is the patch to add the TFTP and WPAD DHCP options. The patch >> is based on openvpn 2.3.7 as I did not know how to do a windows mingw >> build of the git version ... > One way to build a git version on openvpn-build is this: > > $ git clone

Re: [Openvpn-devel] [PATCH] Add TFTP and WPAD DHCP options

2015-07-03 Thread Samuli Seppänen
Attached is the patch to add the TFTP and WPAD DHCP options. The patch is based on openvpn 2.3.7 as I did not know how to do a windows mingw build of the git version ... One way to build a git version on openvpn-build is this: $ git clone $ mv openvpn openvpn-2.3_git $ cd openvpn $ autoreconf

Re: [Openvpn-devel] [PATCH] Add TFTP and WPAD DHCP options

2015-07-02 Thread Gert Doering
Hi, On Thu, Jul 02, 2015 at 11:56:28AM +0200, Jan Just Keijser wrote: > +write_dhcp_str (buf, 66, o->tftp, &error); > +write_dhcp_str (buf, 150, o->tftp, &error); This does not look safe to me (or I'm overlooking something) - if o->tftp is not set, it will do "strlen(o->tftp)" inside wri

Re: [Openvpn-devel] [PATCH] Add TFTP and WPAD DHCP options

2015-07-02 Thread Jan Just Keijser
Hi, On 02/07/15 14:16, Jonathan K. Bullard wrote: On Thu, Jul 2, 2015 at 2:56 AM, Jan Just Keijser wrote: Attached is the patch to add the TFTP and WPAD DHCP options. The patch is based on openvpn 2.3.7 as I did not know how to do a windows mingw build of the git version ... The patch was test

Re: [Openvpn-devel] [PATCH] Add TFTP and WPAD DHCP options

2015-07-02 Thread Jonathan K. Bullard
On Thu, Jul 2, 2015 at 2:56 AM, Jan Just Keijser wrote: > Attached is the patch to add the TFTP and WPAD DHCP options. The patch > is based on openvpn 2.3.7 as I did not know how to do a windows mingw > build of the git version ... > The patch was tested on Windows XP 32bit and Windows 7sp1 64bit.