Re: [Openvpn-devel] [PATCH] Allow "setenv opt" to be pushed from server to client

Hi, On Sat, Oct 29, 2016 at 9:27 AM, Jan Just Keijser wrote: > That apart, NAK to this patch as its not correct > > I'll see if I can refactor the patch - but your suggestion to put it at > the top of add_option did not work for me initially. Its not about refactoring. The

Re: [Openvpn-devel] [PATCH] Allow "setenv opt" to be pushed from server to client

Hi, On 28/10/16 19:50, Selva Nair wrote: Hi, On Fri, Oct 28, 2016 at 6:27 AM, Jan Just Keijser > wrote: --- src/openvpn/options.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) As Arne pointed out the utility of

Re: [Openvpn-devel] [PATCH] Allow "setenv opt" to be pushed from server to client

Hi, On Fri, Oct 28, 2016 at 6:27 AM, Jan Just Keijser wrote: > --- > src/openvpn/options.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > As Arne pointed out the utility of allowing setenv opt in push is questionable. "setenv opt bad-option" in config

Re: [Openvpn-devel] [PATCH] Allow "setenv opt" to be pushed from server to client

Hi Arne, On 28/10/16 13:08, Arne Schwabe wrote: > Hm, > > > I would like to see a rationale why this is needed. The client will > already only warn on unsupported options. Your patch would make push > "setenv opt unsupported" similar to "push unsupported". the rationale behind this is based on an

Re: [Openvpn-devel] [PATCH] Allow "setenv opt" to be pushed from server to client

Hm, I would like to see a rationale why this is needed. The client will already only warn on unsupported options. Your patch would make push "setenv opt unsupported" similar to "push unsupported". Arne -- The Command