Re: [Openvpn-devel] [PATCH] Don't reopen tun if cipher changes

2016-12-15 Thread Steffan Karger
Hi, On 15 December 2016 at 20:49, David Sommerseth wrote: > On 15/12/16 19:52, Steffan Karger wrote: >> -if (strstr(line, "peer-id ") != line) >> +if (strcmp(line, "peer-id ") == 0) > > Are you sure about this strcmp()? I'd expect line to contain > "peer-id 1" or something like t

Re: [Openvpn-devel] [PATCH] Don't reopen tun if cipher changes

2016-12-15 Thread David Sommerseth
On 15/12/16 19:52, Steffan Karger wrote: > When the pulled options change, OpenVPN will attempt to reopen the tun > device. That might fail if the process has already dropper privileges, > and is not needed unless the tun MTU is changed. This patch therefore > ignores the cipher value for the dig