Re: [Openvpn-devel] [PATCH] TAP interface support for Solaris/OpenSolaris

2010-04-29 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 29/04/10 10:08, Gert Doering wrote: > Hi, > > On Thu, Apr 29, 2010 at 10:03:23AM +0200, David Sommerseth wrote: >>> If we include it in feat_ipv6_payload, it won't have merge conflicts - but >>> then you only get the TAP-on-Solaris in combination w

Re: [Openvpn-devel] [PATCH] TAP interface support for Solaris/OpenSolaris

2010-04-29 Thread Gert Doering
Hi, On Thu, Apr 29, 2010 at 10:03:23AM +0200, David Sommerseth wrote: > > If we include it in feat_ipv6_payload, it won't have merge conflicts - but > > then you only get the TAP-on-Solaris in combination with all the IPv6 stuff, > > which people might not want. > > > > David? > > You seem to ha

Re: [Openvpn-devel] [PATCH] TAP interface support for Solaris/OpenSolaris

2010-04-29 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 29/04/10 09:03, Gert Doering wrote: > Hi, > > On Thu, Apr 29, 2010 at 01:02:37PM +0900, Kazuyoshi Aizawa wrote: >> I've attached a patch for tun.c which includes support for tap >> interface for solaris/opensolaris. >> The code is based on OpneVPN

Re: [Openvpn-devel] [PATCH] TAP interface support for Solaris/OpenSolaris

2010-04-29 Thread Gert Doering
Hi, On Thu, Apr 29, 2010 at 04:39:35PM +0900, Kazuyoshi Aizawa wrote: > Thank you for your support. > Please find attached patch with diff -uw. Thanks. I wouldn't claim to understand why the specific changes are needed, but this way it is obvious that the changes really only affect the Solar

Re: [Openvpn-devel] [PATCH] TAP interface support for Solaris/OpenSolaris

2010-04-29 Thread Kazuyoshi Aizawa
Hi Gert, Thank you for your support. Please find attached patch with diff -uw. Thanks, Kazuyoshi 2010/4/29 Gert Doering : > Hi again, > > On Thu, Apr 29, 2010 at 01:02:37PM +0900, Kazuyoshi Aizawa wrote: >> I've attached a patch for tun.c which includes support for tap >> interface for solaris/

Re: [Openvpn-devel] [PATCH] TAP interface support for Solaris/OpenSolaris

2010-04-29 Thread Gert Doering
Hi again, On Thu, Apr 29, 2010 at 01:02:37PM +0900, Kazuyoshi Aizawa wrote: > I've attached a patch for tun.c which includes support for tap > interface for solaris/opensolaris. I've glanced through the patch, and there's also changes in the Win32 part of the tun.c, for example this chunk:

Re: [Openvpn-devel] [PATCH] TAP interface support for Solaris/OpenSolaris

2010-04-29 Thread Gert Doering
Hi, On Thu, Apr 29, 2010 at 01:02:37PM +0900, Kazuyoshi Aizawa wrote: > I've attached a patch for tun.c which includes support for tap > interface for solaris/opensolaris. > The code is based on OpneVPN 2.1.1. And it has a routine to > plumb/unplumb tap interface like ifconfig command. > > tap dr