Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-04-22 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22/04/10 10:15, Davide Brini wrote: > On Thursday 22 Apr 2010 09:02:23 David Sommerseth wrote: > >> For future patches, would you mind adding a little bit more descriptive >> text which can be used as commit log messages. I do write those commit

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-04-22 Thread Davide Brini
On Thursday 22 Apr 2010 09:02:23 David Sommerseth wrote: > For future patches, would you mind adding a little bit more descriptive > text which can be used as commit log messages. I do write those commit > logs when I find it is needed, but adding a little bit more descriptions > of what the

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-04-22 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 19/04/10 23:37, Davide Brini wrote: > On Monday 19 April 2010, David Sommerseth wrote: > >> I've done a quick test on one of my connections on Fedora 12 without any >> resolvconf package (meaning it invokes the simple cp approach), and it >>

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-04-19 Thread Davide Brini
On Monday 19 April 2010, David Sommerseth wrote: > I've done a quick test on one of my connections on Fedora 12 without any > resolvconf package (meaning it invokes the simple cp approach), and it > worked like a charm. > > Applied to bugfix2.1 and merged into allmerged. > Commit

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-04-19 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/03/10 22:41, Davide Brini wrote: > On Wednesday 10 March 2010, David Sommerseth wrote: > >>> Well, I was actually going to write a patch, but shortly after starting I >>> found out that it would end up being essentially the same as Gentoo's >>>

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-03-11 Thread Davide Brini
On Wednesday 10 March 2010, David Sommerseth wrote: > > Well, I was actually going to write a patch, but shortly after starting I > > found out that it would end up being essentially the same as Gentoo's > > scripts. Would it be worth separately maintaining something that has > > already been

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-03-10 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 17:34, Davide Brini wrote: >> > >>The only scripts that actually require bash are >> > >> contrib/pull-resolv-conf/client.{up,down} ; they use the ${!var} >> > >> variable indirection feature. >>> >>> > > Not only that, they also use

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-03-10 Thread Davide Brini
On Wednesday 10 Mar 2010 15:45:32 David Sommerseth wrote: > On 01/03/10 00:26, Davide Brini wrote: > > On Sunday 28 February 2010, David Sommerseth wrote: > >> From: Dan Nelson > >> > >> Many of the scripts in the openvpn source have their shell set to > >>

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-03-10 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/03/10 00:26, Davide Brini wrote: > On Sunday 28 February 2010, David Sommerseth wrote: >> From: Dan Nelson >> >> Many of the scripts in the openvpn source have their shell set to >> /bin/bash, but only two use

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-03-10 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/02/10 22:12, David Sommerseth wrote: > From: Dan Nelson > > Many of the scripts in the openvpn source have their shell set to > /bin/bash, but only two use bash features. The attached patch (against >