On 25/02/17 16:28, Илья Шипицин wrote:
>
> but for "[src/openvpn/error.c:824]: (error) Null pointer dereference",
> I'm afraid we should guard it with "#if 0", otherwise static analyzer
> will continue complain
No. That function in error.c:824, crash(), which is only enabled with
ENABLE_DEBUG is
2017-02-25 19:36 GMT+05:00 Antonio Quartulli :
> On Sat, Feb 25, 2017 at 06:45:36PM +0500, Илья Шипицин wrote:
> > 2017-02-25 16:49 GMT+05:00 David Sommerseth <
> > open...@sf.lists.topphemmelig.net>:
> >
> > > On 25/02/17 10:42, Илья Шипицин wrote:
> > > > there are two another unused functions i
On Sat, Feb 25, 2017 at 06:45:36PM +0500, Илья Шипицин wrote:
> 2017-02-25 16:49 GMT+05:00 David Sommerseth <
> open...@sf.lists.topphemmelig.net>:
>
> > On 25/02/17 10:42, Илья Шипицин wrote:
> > > there are two another unused functions in misc.c
> > >
> > > [src/openvpn/misc.c:661]: (style) The
2017-02-25 16:49 GMT+05:00 David Sommerseth <
open...@sf.lists.topphemmelig.net>:
> On 25/02/17 10:42, Илья Шипицин wrote:
> > there are two another unused functions in misc.c
> >
> > [src/openvpn/misc.c:661]: (style) The function 'env_set_print' is never
> > used.
>
> This one is useful for debug
On 25/02/17 10:42, Илья Шипицин wrote:
> there are two another unused functions in misc.c
>
> [src/openvpn/misc.c:661]: (style) The function 'env_set_print' is never
> used.
This one is useful for debugging purposes, so I let this one stay. I
did consider an #if 0 around it, to make it more expl
there are two another unused functions in misc.c
[src/openvpn/misc.c:661]: (style) The function 'env_set_print' is never
used.
[src/openvpn/misc.c:895]: (style) The function 'setenv_int_i' is never used.
2017-02-25 7:02 GMT+05:00 David Sommerseth :
> The env_set_add_to_environmenti() and env_set
