Re: [Openvpn-devel] [PATCH 1/4] re-implement argv_printf_*()

2020-02-12 Thread Arne Schwabe
Am 06.02.20 um 14:21 schrieb David Sommerseth: > From: Heiko Hund > > The previous implementation had the problem that it was not fully > compatible with printf() and could only detect % format directives > following a space character (0x20). > > It modifies the format string and inserts marks

Re: [Openvpn-devel] [PATCH 1/4] re-implement argv_printf_*()

2020-01-19 Thread Gert Doering
Hi, On Sun, Jan 19, 2020 at 04:51:08PM +0100, Gert Doering wrote: > David, shall I just amend the patch, or do you want to resend a v3? > > (The other 3 of the set should be fine, as they do not touch tun.c) Not exactly correct, 2/4 renames all argv_reset() calls to argv_free(), so that *might*

Re: [Openvpn-devel] [PATCH 1/4] re-implement argv_printf_*()

2020-01-19 Thread Gert Doering
Hi, On Fri, Oct 04, 2019 at 07:12:43PM +0200, David Sommerseth wrote: > From: Heiko Hund > > The previous implementation had the problem that it was not fully > compatible with printf() and could only detect % format directives > following a space character (0x20). Events have overtaken this

Re: [Openvpn-devel] [PATCH 1/4] re-implement argv_printf_*()

2018-10-24 Thread David Sommerseth
On 19/10/18 17:56, David Sommerseth wrote: > From: Heiko Hund > > The previous implementation had the problem that it was not fully > compatible with printf() and could only detect % format directives > following a space character (0x20). > > It modifies the format string and inserts marks to