Re: [Openvpn-devel] Compiling issue on Visual Studio 2010

2015-07-03 Thread Samuli Seppänen
Also I believe Visual Studio provides better security guarantees (like stack canaries, buffer checks etc.). Just for reference: those are supported by mingw/gcc too: -fstack-protector for canaries, -Wl,--nxcompat for DEP, -Wl,--dynamicbase for ASLR. Steffan: so these are the magic incantatio

Re: [Openvpn-devel] Compiling issue on Visual Studio 2010

2015-07-01 Thread Steffan Karger
On Wed, Jul 1, 2015 at 11:29 PM, Fish Wang wrote: > Thank you for the suggestion. I'm sticking with VS since I already have an > entire automation environment set up for compiling OpenVPN with Visual Studio. Fair enough. > Also I believe Visual Studio provides better security guarantees (like s

Re: [Openvpn-devel] Compiling issue on Visual Studio 2010

2015-07-01 Thread Fish Wang
Thank you Steffan, the patch works for me. Best, Fish -Original Message- From: Steffan Karger [mailto:stef...@karger.me] Sent: Wednesday, July 1, 2015 2:28 PM To: Fish Wang Cc: openvpn-devel Subject: Re: [Openvpn-devel] Compiling issue on Visual Studio 2010 On Wed, Jul 1, 2015 at 9:47

Re: [Openvpn-devel] Compiling issue on Visual Studio 2010

2015-07-01 Thread Fish Wang
ginal Message- From: Steffan Karger [mailto:stef...@karger.me] Sent: Wednesday, July 1, 2015 2:16 PM To: Fish Wang Cc: openvpn-devel Subject: Re: [Openvpn-devel] Compiling issue on Visual Studio 2010 Hi, On Wed, Jul 1, 2015 at 9:47 PM, Fish Wang wrote: > Visual Studio 2010 refuses to com

Re: [Openvpn-devel] Compiling issue on Visual Studio 2010

2015-07-01 Thread Steffan Karger
On Wed, Jul 1, 2015 at 9:47 PM, Fish Wang wrote: > The following patch resolves this issue. I think we can do this more simple and robust. See the attached patch. Can you please report if that works for you? Thanks. -Steffan From 6e0073163dd3c13a957f8b1760a81a5ef16e65a9 Mon Sep 17 00:00:00 20

Re: [Openvpn-devel] Compiling issue on Visual Studio 2010

2015-07-01 Thread Steffan Karger
Hi, On Wed, Jul 1, 2015 at 9:47 PM, Fish Wang wrote: > Visual Studio 2010 refuses to compile the latest code on branch release/2.3 > because __func__ is not supported. Microsoft supports __FUNCTION__ instead > of __func__ in their compiler. VS 2013 complains the same. Thanks for reporting. That

Re: [Openvpn-devel] Compiling issue on Visual Studio 2010

2015-07-01 Thread Arne Schwabe
Am 01.07.15 um 21:47 schrieb Fish Wang: > > Hi, > > > > Visual Studio 2010 refuses to compile the latest code on branch > release/2.3 because __func__ is not supported. Microsoft supports > __FUNCTION__ instead of __func__ in their compiler. VS 2013 complains > the same. > > > > The following p