-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 14/12/09 00:05, David Sommerseth wrote:
> On 13/12/09 21:18, Daniel Johnson wrote:
>> David Sommerseth wrote:
>>> - - const char *return_value = NULL;
>>> + aresp[i].resp = NULL;
>
>>> This I didn't think about, but I saw
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 13/12/09 21:18, Daniel Johnson wrote:
> David Sommerseth wrote:
>> - - const char *return_value = NULL;
>> + aresp[i].resp = NULL;
>
>> This I didn't think about, but I saw another potential leak.
>> However, your idea her
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
David Sommerseth wrote:
> - - const char *return_value = NULL;
> + aresp[i].resp = NULL;
>
> This I didn't think about, but I saw another potential leak.
> However, your idea here is clever! But I would probably
> suggest:
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 13/12/09 02:32, Daniel Johnson wrote:
> David Sommerseth wrote:
>> The pam_auth() function calls my_conv(), and if this function
>> gets a match on USERNAME or PASSWORD value in the block around
>> line 562, it calls searchandreplace() which does a
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
David Sommerseth wrote:
> I just decided to do a quick review, I don't believe this has
> made it into openvpn-2.1.0. But from what I see, I have one
> concern in regards to a potential memory leak.
>
> The pam_server() function receives a "message" w
On 11/12/09 18:51, Daniel Johnson wrote:
> Daniel Johnson wrote on 2008-12-12:
>> When I began testing OpenVPN v2.1_rc9 I was having trouble
>> authenticating to the MS Active Directory through auth-pam and Samba.
>> I used the following line in my configs (without the linebreak of
>> course):
>
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Daniel Johnson wrote on 2008-12-12:
> When I began testing OpenVPN v2.1_rc9 I was having trouble
> authenticating to the MS Active Directory through auth-pam and Samba.
> I used the following line in my configs (without the linebreak of
> course):
>
>
