On 04/16/2014 05:24 PM, Gert Doering wrote:
> OK, here's the full patch with this version.
One minor remark: if you add an extra * to the /* of the comment above
get_ssl_library_version(void), the comment becomes a doxygen comment and
will be included in the generated doxygen.
Otherwise, ACK.
-S
Hi,
On Tue, Apr 15, 2014 at 09:42:39AM +0200, Gert Doering wrote:
> Different approach:
>
> char *
> get_ssl_library_version(void)
> {
> static char polar_version[30];
> unsigned int pv = version_get_number();
> sprintf( polar_version, "PolarSSL %d.%d.%d",
> (pv>>24)&0
On 15/04/14 09:42, Gert Doering wrote:> HI,
>
> On Mon, Apr 14, 2014 at 10:18:51PM +0200, David Sommerseth wrote:
>> Regarding your patch - the PolarSSL stuff
>>
>> +char *
>> +get_ssl_library_version(void)
>> +{
>> +static char polar_version[30]; /* "at least 18 bytes in size" */
>> +vers
Hi,
On Tue, Apr 15, 2014 at 11:12:29AM +0200, M. Braun wrote:
> Am 15.04.2014 09:42, schrieb Gert Doering:> char *
> > get_ssl_library_version(void)
> > {
> > static char polar_version[30];
> > unsigned int pv = version_get_number();
> > sprintf( polar_version, "PolarSSL %d.%d.%d",
> >
Hi,
Am 15.04.2014 09:42, schrieb Gert Doering:> char *
> get_ssl_library_version(void)
> {
> static char polar_version[30];
> unsigned int pv = version_get_number();
> sprintf( polar_version, "PolarSSL %d.%d.%d",
> (pv>>24)&0xff, (pv>>16)&0xff, (pv>>8)&0xff );
> ret
HI,
On Mon, Apr 14, 2014 at 10:18:51PM +0200, David Sommerseth wrote:
> Regarding your patch - the PolarSSL stuff
>
> +char *
> +get_ssl_library_version(void)
> +{
> +static char polar_version[30]; /* "at least 18 bytes in size" */
> +version_get_string_full( polar_version );
> +ret
On 14/04/14 21:34, Gert Doering wrote:
> Hi,
>
> On Sun, Apr 13, 2014 at 05:26:13PM +0200, Gert Doering wrote:
>> OpenVPN does not currently report the version of the SSL library it is
>> using - which I'm not sure whether it's by design or just because nobody
>> ever added it. Anyway, right now
Hi,
On Sun, Apr 13, 2014 at 05:26:13PM +0200, Gert Doering wrote:
> OpenVPN does not currently report the version of the SSL library it is
> using - which I'm not sure whether it's by design or just because nobody
> ever added it. Anyway, right now I think we need it, to help future
> cases.
OK,
Hi,
On Mon, Apr 14, 2014 at 09:12:05AM +0200, Jan Just Keijser wrote:
> >- how do I get the library version for PolarSSL?
> void version_get_string_full( char *string )
I really wonder what they smoked when designing this API...
/**
* Get the full version string ("PolarSSL x.y.z").
*
* \param
Hi,
On 14-04-14 09:12, Jan Just Keijser wrote:
> Gert Doering wrote:
>> - if we report it, do we want to report it always (as IV_VER) or only
>> if --push-peer-info is set?
>>
> we're reporting the openvpn version info anyway, so adding the SSL lib
> version would not change much; if it is o
- Opprinnelig melding -
> Fra: "Gert Doering"
> Til: openvpn-devel@lists.sourceforge.net
> Sendt: 13. april 2014 17:26:13
> Emne: [Openvpn-devel] RFD: ssl library version numbers
>
> Hi,
>
> OpenVPN does not currently report the version of the SSL library it is
> using - which I'm not s
Hi Gert,
Gert Doering wrote:
Hi,
OpenVPN does not currently report the version of the SSL library it is
using - which I'm not sure whether it's by design or just because nobody
ever added it. Anyway, right now I think we need it, to help future
cases.
There are a few questions that go along w
Love it. Report always
> On Apr 13, 2014, at 10:26 AM, Gert Doering wrote:
>
> Hi,
>
> OpenVPN does not currently report the version of the SSL library it is
> using - which I'm not sure whether it's by design or just because nobody
> ever added it. Anyway, right now I think we need it, to he
13 matches
Mail list logo
