Re: [Openvpn-devel] [PATCH] Report missing endtags of inline files as warnings

2015-06-30 Thread Arne Schwabe
Am 29.06.15 um 20:22 schrieb Gert Doering: > Hi, > > On Mon, Jun 29, 2015 at 02:46:35PM +0200, Arne Schwabe wrote: >> } >>buf_printf (, "%s", line); >> } >> + if (!endtagfound) >> +msg (M_WARN, "WARNING: Endtag %s missing", close_tag); > Generally speaking, ACK. I wonder

[Openvpn-devel] [PATCH applied] Re: Report missing endtags of inline files as warnings

2015-06-30 Thread Gert Doering
ACK. Your patch has been applied to the master and release/2.3 branch. I've added a reference to trac #568 and made it M_FATAL / "ERROR:" for 2.4, while the release/2.3 patch went in "as is". commit 68eecf76978a80bd5d88e944e4ed5e42bf2fd8e4 (master) commit

Re: [Openvpn-devel] [PATCH] Increase control channel packet size for faster handshakes

2015-06-30 Thread Gert Doering
Hi, On Tue, Jun 30, 2015 at 07:50:16AM +0200, Arne Schwabe wrote: > > Note that this patch does *not* yield an optimal solution, but it is a > > simple and rather safe change that will improve connection setup times > > significantly. > > I have no experience with the code and what happens on a

Re: [Openvpn-devel] [PATCH] Increase control channel packet size for faster handshakes

2015-06-30 Thread Gert Doering
Hi, On Tue, Jun 30, 2015 at 09:57:27AM +0200, Gert Doering wrote: > The option is there, the manpage description of the option "fits", we > just need to make it visible inside ssl.c... :-) - Steffan? ... and while I have the magic wand, another wish .-) - please log a message what MTU we've

Re: [Openvpn-devel] [PATCH] Increase control channel packet size for faster handshakes

2015-06-30 Thread Steffan Karger
On 30-06-15 14:02, Gert Doering wrote: ... and while I have the magic wand, another wish .-) - please log a message what MTU we've decided to use. We *will* see "it does not work!" log files and that might help... Sure! I just compiled it into your local binary. Just use --verb 4 and a

[Openvpn-devel] [PATCH v2] Increase control channel packet size for faster handshakes

2015-06-30 Thread Steffan Karger
Instead of limiting the control channel TCP/UDP packet payload size at '100 bytes + real control channel overhead' (~140 bytes ethernet payload), increase the max TCP/UDP payload size to '1250 bytes - calculated overhead' (~1210 bytes ethernet payload). Note that this patch does *not* yield an