Re: [Openvpn-devel] [PATCH 1/7] put argv_* functions into own file, add unit tests

2016-11-07 Thread David Sommerseth
On 28/10/16 18:42, Heiko Hund wrote: > misc.c is too crowded with different things to perform any > sane unit testing due to its dependencies. So, in order to re-write > the #ifdef'ed tests for the argv_* family of functions into unit > tests I moved them into a dedicated file. > > Signed-off-by:

[Openvpn-devel] [PATCH] clean up *sig_info handling in link_socket_init_phase2()

2016-11-07 Thread Gert Doering
The code was a mix of "assume that it is not NULL" and "check that it is not NULL before using" - it cannot be NULL (due to the single call graph, referencing c->sig with the global context), but for good measure, add an ASSERT() upon function entry and get rid of all the individual checks.

Re: [Openvpn-devel] Topics for the upcoming (Monday, 7th Nov 2016) community meeting

2016-11-07 Thread Gert Doering
Hi, On Mon, Nov 07, 2016 at 07:32:05PM +0200, Samuli Seppänen wrote: > Il 07/11/2016 19:16, ?? ha scritto: > > the automatic update functionality is definetily missing for windows part. > > I'll try chocolatey for that. > > Yeah. The last time I checked (~year ago) setting

Re: [Openvpn-devel] Topics for the upcoming (Monday, 7th Nov 2016) community meeting

2016-11-07 Thread Samuli Seppänen
Il 07/11/2016 19:16, Илья Шипицин ha scritto: > the automatic update functionality is definetily missing for windows part. > I'll try chocolatey for that. Yeah. The last time I checked (~year ago) setting up Chocolatey repos was a bit painful. The "normal" way to setup a repository was to use

Re: [Openvpn-devel] Topics for the upcoming (Monday, 7th Nov 2016) community meeting

2016-11-07 Thread Samuli Seppänen
Il 07/11/2016 15:15, Илья Шипицин ha scritto: > Hello, > > I used @mattock's powershell scripts > > voila :) > > https://jk.testkontur.ru/job/openvpn%20connect%20to%20jk-test/3/console > > it is strange for few reasons, but it looks very promising. we can > automate a lot of testing in such way.

Re: [Openvpn-devel] Topics for the upcoming (Monday, 7th Nov 2016) community meeting

2016-11-07 Thread Илья Шипицин
Hello, I used @mattock's powershell scripts voila :) https://jk.testkontur.ru/job/openvpn%20connect%20to%20jk-test/3/console it is strange for few reasons, but it looks very promising. we can automate a lot of testing in such way. 2016-11-04 14:32 GMT+05:00 Samuli Seppänen

[Openvpn-devel] [PATCH applied] Re: openvpn version line: remove [IPv6], add [AEAD] if available

2016-11-07 Thread Gert Doering
Patch has been applied to the master branch. commit 2391a3ab08227a061a7f561e26b9688f6ba80e70 Author: Gert Doering Date: Mon Nov 7 11:50:52 2016 +0100 openvpn version line: remove [IPv6], add [AEAD] if available Signed-off-by: Gert Doering Acked-by: Steffan

Re: [Openvpn-devel] Topics for the upcoming (Monday, 7th Nov 2016) community meeting

2016-11-07 Thread Samuli Seppänen
Il 07/11/2016 18:56, Илья Шипицин ha scritto: > > > 2016-11-07 20:50 GMT+05:00 Samuli Seppänen >: > > Il 07/11/2016 15:15, Илья Шипицин ha scritto: > > Hello, > > I used @mattock's powershell scripts > > voila :) > >

Re: [Openvpn-devel] Topics for the upcoming (Monday, 7th Nov 2016) community meeting

2016-11-07 Thread Илья Шипицин
2016-11-07 20:50 GMT+05:00 Samuli Seppänen : > Il 07/11/2016 15:15, Илья Шипицин ha scritto: > >> Hello, >> >> I used @mattock's powershell scripts >> >> voila :) >> >> https://jk.testkontur.ru/job/openvpn%20connect%20to%20jk-test/3/console >> >> it is strange for few reasons,

Re: [Openvpn-devel] Topics for the upcoming (Monday, 7th Nov 2016) community meeting

2016-11-07 Thread Илья Шипицин
the automatic update functionality is definetily missing for windows part. I'll try chocolatey for that. 2016-11-07 22:11 GMT+05:00 Samuli Seppänen : > Il 07/11/2016 18:56, Илья Шипицин ha scritto: > >> >> >> 2016-11-07 20:50 GMT+05:00 Samuli Seppänen >

Re: [Openvpn-devel] [PATCH] systemd: Improve the systemd unit files

2016-11-07 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/11/16 16:07, debbie10t wrote: > Hi, > > I have tested these two unit files on Archlinux, CentOS7, Debian8, > Fedora 24, OpenSuse 42 and Ubuntu 16.04 and they all work. I tested > for a week, starting ,stopping, restarting and rebooting on 1 >

[Openvpn-devel] [PATCH] openvpn version line: remove [IPv6], add [AEAD] if available

2016-11-07 Thread Gert Doering
Printing [IPv6] is no longer relevant information, as IPv6 support is always build in. So, "2.4 = has IPv6, always". [AEAD] is relevant information, as the underlying SSL library might be too old to have support for it (OpenSSL 0.9.x) and this eases figuring out why NCP is not upgrading a

Re: [Openvpn-devel] [PATCH] openvpn version line: remove [IPv6], add [AEAD] if available

2016-11-07 Thread Steffan Karger
On 07-11-16 11:50, Gert Doering wrote: > Printing [IPv6] is no longer relevant information, as IPv6 support > is always build in. So, "2.4 = has IPv6, always". > > [AEAD] is relevant information, as the underlying SSL library might > be too old to have support for it (OpenSSL 0.9.x) and this

[Openvpn-devel] Summary of today's (Monday, 7th Nov 2016) community meeting

2016-11-07 Thread Samuli Seppänen
Hi, Here's the summary of today's IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on irc.freenode.net Date: Monday 7th November 2016 Time: 20:00 CET (19:00 UTC) Planned meeting topics for this meeting were here: The

Re: [Openvpn-devel] [PATCH] systemd: Improve the systemd unit files

2016-11-07 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/11/16 16:07, debbie10t wrote: > > I would say that these .service files are likely to temporarily > break (m)any existing systemd usage until admins change their > configs. Especially use of --cd > I forgot to comment this one. No existing