Re: [Openvpn-devel] [PATCH] Document that tls-crypt also supports inline

2016-11-19 Thread Steffan Karger
On 19-11-16 04:03, Arne Schwabe wrote: > --- > doc/openvpn.8 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/openvpn.8 b/doc/openvpn.8 > index e997b09..11564af 100644 > --- a/doc/openvpn.8 > +++ b/doc/openvpn.8 > @@ -6613,9 +6613,9 @@ X509_1_C=KG > .SH INLINE F

[Openvpn-devel] [PATCH applied] Re: Document that tls-crypt also supports inline

2016-11-19 Thread Gert Doering
Your patch has been applied to the master branch. commit 8025a62c63193d9a3c70033956342b86e01f01fc Author: Arne Schwabe Date: Sat Nov 19 04:03:44 2016 +0100 Document that tls-crypt also supports inline Acked-by: Steffan Karger Message-Id: <1479524624-13863-1-git-send-email-a...@

[Openvpn-devel] [PATCH] Remove compat-stdbool.h.

2016-11-19 Thread Arne Schwabe
Since we use C99, we are guaranteed to have stdbool.h available --- src/compat/compat-stdbool.h | 12 src/openvpn/syshead.h | 2 +- 2 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 src/compat/compat-stdbool.h diff --git a/src/compat/compat-stdbool.h b/src/c

[Openvpn-devel] [PATCH] Fix various compiler warnings

2016-11-19 Thread Arne Schwabe
- move p2mp only push_option_fmt to p2mp only section to avoid warning that struct push_list being defined in the argument list - incoming_push_message not declared on client without server by putting it into the right define block --- src/openvpn/push.c | 49

[Openvpn-devel] [PATCH] Fix warning that RAND_bytes is undeclared

2016-11-19 Thread Arne Schwabe
--- src/openvpn/crypto_openssl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c index 1ea06bb..306b6c6 100644 --- a/src/openvpn/crypto_openssl.c +++ b/src/openvpn/crypto_openssl.c @@ -47,6 +47,7 @@ #include #include #include +#

[Openvpn-devel] openvpn-gui disconnect on suspend ?

2016-11-19 Thread Илья Шипицин
Hello, I see that option in Changes.rst, but I do not see any reference in code: [ilia@localhost openvpn-gui]$ grep -r disconnect_on_suspend . ./CHANGES.rst:Registry option "disconnect_on_suspend". Set to zero to disable the [ilia@localhost openvpn-gui]$ https://github.com/OpenVPN/openvpn-build

Re: [Openvpn-devel] openvpn-gui disconnect on suspend ?

2016-11-19 Thread Selva Nair
Hi, On Sat, Nov 19, 2016 at 11:06 AM, Илья Шипицин wrote: > I see that option in Changes.rst, but I do not see any reference in code: > > [ilia@localhost openvpn-gui]$ grep -r disconnect_on_suspend . > ./CHANGES.rst:Registry option "disconnect_on_suspend". Set to zero to > disable the > [ilia@lo

[Openvpn-devel] [PATCH] multi_process_float: revert part of c14c4a9e

2016-11-19 Thread Steffan Karger
Commit c14c4a9e merged the hash_remove() and hash_add() calls in multi_process_float(), but didn't notice that the hash key (mi->real) was updated between these calls. So we now try to remove the *new* address instead of the *old* address from the hash table. This leaks memory and might break stu

[Openvpn-devel] [PATCH applied] Re: multi_process_float: revert part of c14c4a9e

2016-11-19 Thread Gert Doering
ACK. Explanation makes sense :) - the original change was "too easy"... Your patch has been applied to the master branch. commit c593885997e32a683f718138f7b9273d720c63e3 Author: Steffan Karger Date: Sat Nov 19 18:12:46 2016 +0100 multi_process_float: revert part of c14c4a9e Signed-

[Openvpn-devel] [PATCH applied] Re: Fix warning that RAND_bytes is undeclared

2016-11-19 Thread Gert Doering
Your patch has been applied to the master branch. commit 6ede22c4f58c7d32967299d6a71cda93c88dd656 Author: Arne Schwabe Date: Sat Nov 19 16:51:00 2016 +0100 Fix warning that RAND_bytes is undeclared Acked-by: Gert Doering Message-Id: <1479570660-23630-1-git-send-email-a...@rfc25

[Openvpn-devel] [PATCH applied] Re: Remove compat-stdbool.h.

2016-11-19 Thread Gert Doering
ACK. Your patch has been applied to the master branch. commit 35be7e0d556a6b76e30f1e7348319e9dedf829aa Author: Arne Schwabe Date: Sat Nov 19 16:35:56 2016 +0100 Remove compat-stdbool.h. Acked-by: Gert Doering Message-Id: <1479569756-23302-1-git-send-email-a...@rfc2549.org>

[Openvpn-devel] [PATCH applied] Re: Fix various compiler warnings

2016-11-19 Thread Gert Doering
ACK. Your patch has been applied to the master branch. commit 3212d0c0a5caac6607b30effb584887eb3325942 Author: Arne Schwabe Date: Sat Nov 19 16:42:44 2016 +0100 Fix various compiler warnings Acked-by: Gert Doering Message-Id: <1479570164-23522-1-git-send-email-a...@rfc2549.org

Re: [Openvpn-devel] [PATCH] Remove compat-stdbool.h.

2016-11-19 Thread Gert Doering
Hi, On Sat, Nov 19, 2016 at 04:35:56PM +0100, Arne Schwabe wrote: > Since we use C99, we are guaranteed to have stdbool.h available > --- > src/compat/compat-stdbool.h | 12 > src/openvpn/syshead.h | 2 +- > 2 files changed, 1 insertion(+), 13 deletions(-) > delete mode 10064

Re: [Openvpn-devel] [PATCH] Remove compat-stdbool.h.

2016-11-19 Thread Steffan Karger
On 19 Nov 2016 9:13 p.m., "Gert Doering" wrote: > On Sat, Nov 19, 2016 at 04:35:56PM +0100, Arne Schwabe wrote: > > Since we use C99, we are guaranteed to have stdbool.h available > > --- > > src/compat/compat-stdbool.h | 12 > > src/openvpn/syshead.h | 2 +- > > 2 files chang

[Openvpn-devel] [PATCH] Remove remaining traces of compat-stdbool.h

2016-11-19 Thread Gert Doering
commit 35be7e0d5 removed most references to compat-stdbool.h but overlooked configure and "make dist" Signed-off-by: Gert Doering --- configure.ac | 2 +- src/compat/Makefile.am | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 4a45f