Re: [Openvpn-devel] helping developers to collaborate properly

2017-01-12 Thread Samuli Seppänen 
Il 06/01/2017 18:06, Илья Шипицин ha scritto:
>
>
> 2017-01-06 15:52 GMT+03:00 David Sommerseth
>  >:
>
> On 06/01/17 09:18, Илья Шипицин wrote:
> > Hello,
> >
> > https://github.com/OpenVPN/openvpn/pull/77
> 
> >
> > I'm not sure about exact text (I need help from you),
> > the idea behind those changes is to point developers who use regular
> > github workflow to a proper procedures (maybe there're pages on wiki ?
> > @mattock  ?)
> >
> > it will help to not lose PRs and will probably save time of current
> > developers
>
> Two questions:
>
> 1) Can you explain what those .github/ files does?
>
>
> those files are mark down templates for new PRs and new issues.
> when someone open new PR, he sees such a template
>
> https://github.com/blog/2111-issue-and-pull-request-templates
>

Having a ".github/PULL_REQUEST_TEMPLATE.md" makes sense. Have you tested 
if ".github/PULL_REQUEST_TEMPLATE.rst" works as well? Rst is what we use 
elsewhere.

As for the contents - what about this (in .rst syntax):

Thank you for your contribution
###

You are welcome to open PR, but they are used for discussion only. All 
patches must eventually go to the openvpn-devel mailing list for review. 
For details, see these Wiki articles:

* https://community.openvpn.net/openvpn/wiki/Contributing
* https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation

---

I updated the articles so that they don't contradict what the above 
PULL_REQUEST_TEMPLATE.rst would say.


-- 
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc

irc freenode net: mattock

--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH v2] More broadly enforce Allman style and braces-around-conditionals

2017-01-12 Thread Steffan Karger 

On 12-01-17 02:14, David Sommerseth wrote:
> So I tried to apply this one, but there are some odd issues now.  Did
> you apply your changes against the proper branch locally?  Because a
> couple of these ones are really odd.

Oops, indeed, this one seems to be based on my local branch with lots of
extra commits.  Sorry for that.  I'll send a v3.

-Steffan

--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH v2] convert *_inline attributes to bool

2017-01-12 Thread Steffan Karger 

On 12-01-17 16:54, Antonio Quartulli wrote:
> On Wed, Jan 11, 2017 at 02:32:37PM +0800, Antonio Quartulli wrote:
>> On Tue, Jan 10, 2017 at 10:35:10PM +0100, Steffan Karger wrote:
 @@ -6496,7 +6531,7 @@ add_option(struct options *options,
  else if (streq(p[0], "push") && p[1] && !p[2])
  {
  VERIFY_PERMISSION(OPT_P_PUSH);
 -push_options(options, [1], msglevel, >gc);
 +push_options(options, [1], is_inline, msglevel, >gc);
>>>
>>> Same as with 'plugin', I don't think we can inline a 'push' option?
>>
>>
>> My understanding is that the code allows for push-options to be inline'd, but
>> right now there is no push-option that can be used that way. Am I wrong?
> 
> This said, I agree that we should just not support pushing inline options.
> As of now, none of the 'inlineable' options can be pushed.
> 
> I'll send v3 soon!

Great!  I don't think inline push options would work in general, because
the push string is formatted like "option value, option2 value, ...".
Inline options can contain thinks like line breaks, which would be
unclear how to transform that to the push string.

Maybe even error out if(inline==true) ?

-Steffan

--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH v2] convert *_inline attributes to bool

2017-01-12 Thread Antonio Quartulli 
On Wed, Jan 11, 2017 at 02:32:37PM +0800, Antonio Quartulli wrote:
> On Tue, Jan 10, 2017 at 10:35:10PM +0100, Steffan Karger wrote:
> > > @@ -6496,7 +6531,7 @@ add_option(struct options *options,
> > >  else if (streq(p[0], "push") && p[1] && !p[2])
> > >  {
> > >  VERIFY_PERMISSION(OPT_P_PUSH);
> > > -push_options(options, [1], msglevel, >gc);
> > > +push_options(options, [1], is_inline, msglevel, >gc);
> > 
> > Same as with 'plugin', I don't think we can inline a 'push' option?
> 
> 
> My understanding is that the code allows for push-options to be inline'd, but
> right now there is no push-option that can be used that way. Am I wrong?

This said, I agree that we should just not support pushing inline options.
As of now, none of the 'inlineable' options can be pushed.


I'll send v3 soon!

Thanks!


Cheers,



-- 
Antonio Quartulli


signature.asc
Description: Digital signature
--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] Poll about future community meeting schedules

2017-01-12 Thread Samuli Seppänen 
Hi,

I the previous community meeting[1] I promised to setup a poll to 
determine which weekdays / times work best for those who actively 
participate in the community meetings. So here it is:



If you have not been an active participant in the meetings please do not 
fill the poll. Also, please disregard the absolute dates which are a 
meaningless in this context.

All the times are in CET (Germany/Berlin in Doodle).

-- 
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc

irc freenode net: mattock


[1] 


--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel