Re: [Openvpn-devel] [PATCH] crypto: create function to initialize encrypt and decrypt key

2017-07-07 Thread Antonio Quartulli
Antonio Quartulli: > From: Steffan Karger > > Instead of always initialize the encrypt and decrypt keys separately, > implement an helper function init_key_ctx_bi() that takes care of > both of them for us. > > Reduces code duplication and improves readability. > > Acked-by: Antonio Quartulli

Re: [Openvpn-devel] [PATCH] crypto: create function to initialize encrypt and decrypt key

2017-07-07 Thread Antonio Quartulli
Antonio Quartulli: >> Acked-by: Antonio Quartulli >> Signed-off-by: Steffan Karger > > I have to retreat my ACK. This patch is generating some new warnings > that have to be fixed before being considered for merging. > Sorry, please ignore my previous email. I am working with too many branche

[Openvpn-devel] [PATCH] tls-crypt: avoid warnings when --disable-crypto is used

2017-07-07 Thread Antonio Quartulli
From: Antonio Quartulli Avoid including the content of tls_crypt.h when --disable-crypto is used, as it will trigger some warnings due to missing structures declarations. Signed-off-by: Antonio Quartulli --- - also checked via travis-ci.org src/openvpn/tls_crypt.h | 4 1 file changed, 4

[Openvpn-devel] [PATCH] management: preserve wait_for_push field when asking for user/pass

2017-07-07 Thread Antonio Quartulli
With the introduction of the wait_for_push field in the auth_user_pass structure, we have to make sure that such field is not accidentally erased when the management asks the user for user/pass. Erasing such field would mess up the logic introduced by ("Ignore auth-nocache for auth-user-pass if au

[Openvpn-devel] RFCv2: Yubikey authentication for OpenVPN

2017-07-07 Thread Steven Haigh
Hi all, I have attached this script for comment to be considered for inclusion in the contrib section of openvpn to use the Yubico Yubicloud authentication for the Yubikey OTP. Setup instructions are included in the top of the script file. There is a current patch pending merging to fix client

Re: [Openvpn-devel] [PATCH] Implement block-ipv6

2017-07-07 Thread Jonathan K. Bullard
Hi. I have one small nit-pick. On Thu, Jul 6, 2017 at 11:33 AM, Arne Schwabe wrote: > This can be used to redirect all IPv6 traffic to the tun interface, > effectively black holing the IPv6 traffic. Without ICMPv6 error messages this > will result in timeouts when the server does not send erro

[Openvpn-devel] [PATCH] Fix socks_proxy_port pointing to invalid data

2017-07-07 Thread Thomas Veerman via Openvpn-devel
When setting the SOCKS proxy through the management interface, the socks_proxy_port pointer would be set to a value that's no longer valid by the time it's used by do_preresolve_host. Signed-off-by: Thomas Veerman --- src/openvpn/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Openvpn-devel] [PATCH] Fix socks_proxy_port pointing to invalid data

2017-07-07 Thread Arne Schwabe
Am 07.07.17 um 21:59 schrieb Thomas Veerman via Openvpn-devel: > When setting the SOCKS proxy through the management interface, the > socks_proxy_port pointer would be set to a value that's no longer valid > by the time it's used by do_preresolve_host. > > Signed-off-by: Thomas Veerman > --- > s

Re: [Openvpn-devel] [PATCH] tls-crypt: avoid warnings when --disable-crypto is used

2017-07-07 Thread Steffan Karger
Hi, On 07-07-17 12:22, Antonio Quartulli wrote: > From: Antonio Quartulli > > Avoid including the content of tls_crypt.h when --disable-crypto > is used, as it will trigger some warnings due to missing > structures declarations. > > Signed-off-by: Antonio Quartulli > --- > > - also checked vi

Re: [Openvpn-devel] [PATCH] Fix socks_proxy_port pointing to invalid data

2017-07-07 Thread Christian Hesse
Thomas Veerman via Openvpn-devel on Fri, 2017/07/07 21:59: > else if (streq(p[1], "SOCKS")) > { > ce->socks_proxy_server = string_alloc(p[2], gc); > -ce->socks_proxy_port = p[3]; > +ce->socks_proxy_port = string_alloc(p[3], gc); >

Re: [Openvpn-devel] [PATCH] Fix socks_proxy_port pointing to invalid data

2017-07-07 Thread David Sommerseth
On 07/07/17 23:11, Christian Hesse wrote: > Thomas Veerman via Openvpn-devel on > Fri, 2017/07/07 21:59: >> else if (streq(p[1], "SOCKS")) >> { >> ce->socks_proxy_server = string_alloc(p[2], gc); >> -ce->socks_proxy_port = p[3]; >> +ce->socks_

Re: [Openvpn-devel] [PATCH] crypto: create function to initialize encrypt and decrypt key

2017-07-07 Thread Steffan Karger
Hi, On 07-07-17 06:47, Antonio Quartulli wrote: > From: Steffan Karger > > Instead of always initialize the encrypt and decrypt keys separately, > implement an helper function init_key_ctx_bi() that takes care of > both of them for us. > > Reduces code duplication and improves readability. > >

[Openvpn-devel] RFCv3: Yubikey authentication for OpenVPN

2017-07-07 Thread Steven Haigh
Hi all, I have attached this script for comment to be considered for inclusion in the contrib section of openvpn to use the Yubico Yubicloud authentication for the Yubikey OTP. Setup instructions are included in the top of the script file. There is a current patch pending merging to fix client