Your patch has been applied to the master branch.
Have only done a cursory review + "make check" since David did the
thorough review already. One small code wart...
+if (options->mlock && (options->genkey))
(asymmetric brackets) ... we can fix that when we pass here next time...
I have
GCC 9 no longer accepts this flag and trying to find out what it does do
leads to an article
"-no-cpp-precomp: the compiler flag that time forgot"
that also no longer on the Internet. And most other things are
PRs/commits from over ten years ago that remove the flag since it
is no longer needed.
Acked-by: Gert Doering
Explanation makes sense :-)
Your patch has been applied to the master and release/2.4 branch.
commit 0740e079a1c094627a69b8b5959c6be56e15d9f6 (master)
commit c39b46e5fa0a73a1959bba30a9ca1ee59feb544b (release/2.4)
Author: Arne Schwabe
Date: Fri Jul 5 13:42:43 2019 +0200
Am 05.07.19 um 15:00 schrieb Gert Doering:
> commit 0c1cc8d65539f removed "DWORD len;" from service_enable_dhcp(),
> but that variable is far from "unused" - breaking compilation.
>
> The problem here was that it's a larger "cleanup compiler warnings"
> patch which was fully correct for master,
Your patch has been applied to the release/2.4 branch.
commit 5b1d07906073702b9fb23ca97f69bc8ba324f609
Author: Gert Doering
Date: Fri Jul 5 15:00:01 2019 +0200
repair windows builds (2.4)
Signed-off-by: Gert Doering
Acked-by: Arne Schwabe
Message-Id:
commit 0c1cc8d65539f removed "DWORD len;" from service_enable_dhcp(),
but that variable is far from "unused" - breaking compilation.
The problem here was that it's a larger "cleanup compiler warnings"
patch which was fully correct for master, but this particular function
looks different in
Your patch has been applied to the master branch.
I have adjusted the comment as David suggested. Not much to test yet,
as the new code is not used yet.
commit fb4e8abca908d90faa98f20125e49a2590bccaa3
Author: Arne Schwabe
Date: Thu Jun 13 15:48:30 2019 +0200
Add generate_ephemeral_key
