When provisioning IP configuration, we shall not ask what kind of
adapter this is. Rather, we should ask what method of provisioning we
are configured to use.
It is options.c's job to rule out invalid combinations.
- do_ifconfig_ipv4(): unify the workflow with its IPv6 counterpart
No need to
Hi,
On Thu, Mar 12, 2020 at 05:03:23AM +0200, Lev Stipakov wrote:
> This option can be used in FreedBSD with devel/libinotify
> installed.
>
> Detect presence of libinotify and link with its _LIBS variable.
>
> Trac #1256
>
> Signed-off-by: Lev Stipakov
Doesn't want to work for me...
Your patch has been applied to the master branch.
No testing done on my side, but from a stare-at-code perspective this
looks reasonable & necessary. Thanks.
commit 5d28b47c51f4fcef631f9dae83f9cbc7120c6812
Author: Lev Stipakov
Date: Thu Mar 12 08:08:29 2020 +0200
tun.c: fix 'use after
Hi,
On Fri, Mar 13, 2020 at 02:47:39AM +, Simon Rozman wrote:
> True. I'm sure I got this in the original commit back then. Found it... When
> rebasing onto the current master, it conflicted and I dropped that change
> rather than fixing it. Wrong choice, sorry.
Am I reading this
Your patch has been applied to the master branch.
I did a cursory review and the changes look good (the ACK is Lev's,
though :-) ). Test compiled on Ubuntu 16.04/MinGW for good measure.
commit f3ef6ced23b659855ac8b957e147fa8b58578098
Author: Simon Rozman
Date: Tue Mar 10 10:48:21 2020 +0100
This option can be used in FreedBSD with devel/libinotify
installed.
Detect presence of libinotify with pkgconf and use its word
to compile and link.
Signed-off-by: Lev Stipakov
---
v3: use _CFLAGS from pkgconf to get include dir
v2: use _LIBS from pkgcong instead of hardcoded -linotify
