Re: [Openvpn-devel] [PATCH] Fix IPv6 configuration on Windows using netsh

2020-04-20 Thread Gert Doering
Hi, On Mon, Apr 20, 2020 at 02:28:28PM +0200, Arne Schwabe wrote: > Am 27.11.19 um 14:43 schrieb Laurent Fasnacht: > > Apparently, `netsh interface ipv6 set address ...` defaults to using > > a subnet of /64, and therefore adds an onlink route of that size. Ah, there the patch is. I was looking

Re: [Openvpn-devel] [PATCH] Fix IPv6 configuration on Windows using netsh

2020-04-20 Thread Arne Schwabe
Am 27.11.19 um 14:43 schrieb Laurent Fasnacht: > Apparently, `netsh interface ipv6 set address ...` defaults to using > a subnet of /64, and therefore adds an onlink route of that size. > > When using a tun tunnel, the tap adapter only replies to neighbor > discovery packets for fe80::8. This

[Openvpn-devel] [PATCH v2] Do not write extra 0 byte for --gen-key with auth-token/tls-crypt-v2

2020-04-20 Thread Arne Schwabe
Change crypto_pem_encode to not put a nul-terminated terminated string into the buffer. This was useful for printf but should not be written into the file. Instead do not assume that the buffer is null terminated and print only the number of bytes in the buffer. Also fix a similar case in

[Openvpn-devel] [PATCH] Add tls-crypt-v2 test writing metadata

2020-04-20 Thread Arne Schwabe
--- tests/unit_tests/openvpn/test_tls_crypt.c | 44 +-- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/tests/unit_tests/openvpn/test_tls_crypt.c b/tests/unit_tests/openvpn/test_tls_crypt.c index b9e3a7a6..91a4d209 100644 ---

Re: [Openvpn-devel] [PATCH] remove bogus file check on --genkey argument

2020-04-20 Thread Arne Schwabe
Am 20.04.20 um 12:21 schrieb Antonio Quartulli: > When invoking openvpn as standalone with the --genkey > argument, options_postprocess() is not called at all > because do_genkey() takes over the execution earlier. > > For this reason, checking the --genkey argument in >

[Openvpn-devel] [PATCH applied] Re: remove bogus file check on --genkey argument

2020-04-20 Thread Gert Doering
Acked-by: Gert Doering "If you say so" :-) (haven't looked more closely than "it compiles and does not introduce/modify possibly dangerous code paths"). Your patch has been applied to the master branch. commit c40679fbb051228f6c5108adaa9f6fc6929b1e0f (master) Author: Antonio Quartulli Date:

[Openvpn-devel] [PATCH] remove bogus file check on --genkey argument

2020-04-20 Thread Antonio Quartulli
When invoking openvpn as standalone with the --genkey argument, options_postprocess() is not called at all because do_genkey() takes over the execution earlier. For this reason, checking the --genkey argument in options_postprocess_filechecks() is a no-op. Geti rid of the bogus check altogether.

Re: [Openvpn-devel] OpenVPN 2.4.9 released

2020-04-20 Thread Christian Hesse
Samuli Seppänen on Mon, 2020/04/20 09:13: > On a related note: I think we should consider stopping the distribution > of the security list's public key from our webservers and just instruct > people to fetch the key from the keyservers and refresh it if they have > trouble. Key server operation

Re: [Openvpn-devel] OpenVPN 2.4.9 released

2020-04-20 Thread Samuli Seppänen
Hi, Il 19/04/20 13:03, Gert Doering ha scritto: > Hi, > > On Sat, Apr 18, 2020 at 02:30:46PM +0200, Simon Matter wrote: >> A long time ago I was asking them to also show MD5/SHAXXX checksums so I >> can easily verify the downloads. My request was turned down for reasons I >> still don't