Re: [Openvpn-devel] [PATCH 3/5] Allow running a default configuration with TLS libraries without BF-CBC

2021-01-22 Thread Antonio Quartulli
Hi, On 22/01/2021 12:19, Arne Schwabe wrote: >> I would suggest some refactoring here. >> We can just assume that BF-CBC is not supported by the SSL library, >> while also reducing some code duplication: >> >> const char *ciphername = o->ciphername; >> >> ... >> >> /* o->ciphername might be

Re: [Openvpn-devel] [PATCH 3/5] Allow running a default configuration with TLS libraries without BF-CBC

2021-01-22 Thread Arne Schwabe
> >> +init_key_type(>c1.ks.key_type, options->ciphername, >> options->authname, >> + options->keysize, true, true); >> +} > Why do you always want to warn the user in this context? > By passing warn=true all the time (last argument) we will have