Re: [Openvpn-devel] [PATCH v3] tun: remove tun_finalize()

2022-01-19 Thread Lev Stipakov
Gentle nudge. ma 17. tammik. 2022 klo 13.42 Gert Doering (g...@greenie.muc.de) kirjoitti: > > Hi, > > On Mon, Jan 17, 2022 at 11:56:51AM +0200, Lev Stipakov wrote: > > This is probably something committer (looks at cron2) could fix on the > > fly, unless there are more issues which would require

[Openvpn-devel] [PATCH] crypto: Fix OPENSSL_FIPS enabled builds

2022-01-19 Thread David Sommerseth
From: David Sommerseth On Fedora and RHEL/CentOS, the standard OpenSSL library has the FIPS module enabled by default. This revealed some incompatible code with the added DCO support. Signed-off-by: David Sommerseth --- src/openvpn/crypto.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [Openvpn-devel] [PATCH v2] crypto: Fix OPENSSL_FIPS enabled builds

2022-01-19 Thread Arne Schwabe
Am 19.01.22 um 16:19 schrieb David Sommerseth: From: David Sommerseth On Fedora and RHEL/CentOS, the standard OpenSSL library has the FIPS module enabled by default. On these platforms, the OPENSSL_FIPS macro is always defined via /usr/include/openssl/opensslconf-*.h. Acked-By: Arne Schwabe

Re: [Openvpn-devel] [PATCH v2] crypto: Fix OPENSSL_FIPS enabled builds

2022-01-19 Thread Selva Nair
Hi, Sorry for chiming in late: On Wed, Jan 19, 2022 at 10:20 AM David Sommerseth < open...@sf.lists.topphemmelig.net> wrote: > From: David Sommerseth > > On Fedora and RHEL/CentOS, the standard OpenSSL library has the FIPS > module enabled by default. On these platforms, the OPENSSL_FIPS

Re: [Openvpn-devel] [PATCH v2] crypto: Fix OPENSSL_FIPS enabled builds

2022-01-19 Thread David Sommerseth
On 19/01/2022 17:34, Selva Nair wrote: Hi, Sorry for chiming in late: On Wed, Jan 19, 2022 at 10:20 AM David Sommerseth > wrote: From: David Sommerseth mailto:dav...@openvpn.net>> On Fedora and RHEL/CentOS, the standard OpenSSL library has

[Openvpn-devel] [PATCH v3] crypto: Fix OPENSSL_FIPS enabled builds

2022-01-19 Thread David Sommerseth
From: David Sommerseth On Fedora and RHEL/CentOS, the standard OpenSSL library has the FIPS module enabled by default. On these platforms, the OPENSSL_FIPS macro is always defined via /usr/include/openssl/opensslconf-*.h. Without this fix, the following compilation error appears:

[Openvpn-devel] Summary of the community meeting (19th Jan 2022)

2022-01-19 Thread Samuli Seppänen
Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on libera.chat Date: Wed 19th January 2022 Time: 10:30 CET (9:30 UTC) Planned meeting topics for this meeting were here: Your local

Re: [Openvpn-devel] [PATCH] crypto: Fix OPENSSL_FIPS enabled builds

2022-01-19 Thread Arne Schwabe
Am 19.01.22 um 12:34 schrieb David Sommerseth: From: David Sommerseth On Fedora and RHEL/CentOS, the standard OpenSSL library has the FIPS module enabled by default. This revealed some incompatible code with the added DCO support. Signed-off-by: David Sommerseth --- src/openvpn/crypto.c |

Re: [Openvpn-devel] [PATCH] crypto: Fix OPENSSL_FIPS enabled builds

2022-01-19 Thread Antonio Quartulli
Hi David, On 19/01/2022 12:34, David Sommerseth wrote: From: David Sommerseth On Fedora and RHEL/CentOS, the standard OpenSSL library has the FIPS module enabled by default. This revealed some incompatible code with the added DCO support. Signed-off-by: David Sommerseth ---

Re: [Openvpn-devel] [PATCH] crypto: Fix OPENSSL_FIPS enabled builds

2022-01-19 Thread David Sommerseth
On 19/01/2022 14:44, Antonio Quartulli wrote: Hi David, On 19/01/2022 12:34, David Sommerseth wrote: From: David Sommerseth On Fedora and RHEL/CentOS, the standard OpenSSL library has the FIPS module enabled by default.  This revealed some incompatible code with the added DCO support.

[Openvpn-devel] [PATCH v2] crypto: Fix OPENSSL_FIPS enabled builds

2022-01-19 Thread David Sommerseth
From: David Sommerseth On Fedora and RHEL/CentOS, the standard OpenSSL library has the FIPS module enabled by default. On these platforms, the OPENSSL_FIPS macro is always defined via /usr/include/openssl/opensslconf-*.h. Without this fix, the following compilation error appears:

[Openvpn-devel] [PATCH] GitHub Actions: add other config flavours

2022-01-19 Thread Antonio Quartulli
In the past we had issues with patches accidentally breaking less common OpenVPN configurations. For this reason it makes sense to some of those configurations build via CI. Adding: * --enable-iproute2 * --enable-async-push * --disable-management * --enable-small * --disable-lzo * --disable-lz4

Re: [Openvpn-devel] [PATCH] GitHub Actions: add other config flavours

2022-01-19 Thread Gert Doering
Hi, On Thu, Jan 20, 2022 at 12:27:43AM +0100, Antonio Quartulli wrote: > * --disable-lzo > * --disable-lz4 Not sure having them individually does much good, but we definitely want a config with "disable all compression" (--disable-lzo --disable-lz4). This was what we broke last time :-) (And