NACK. See below.
On Sun, Jun 26, 2022 at 01:41:49AM +0200, Arne Schwabe wrote:
> diff --git a/tests/unit_tests/openvpn/test_crypto.c
> b/tests/unit_tests/openvpn/test_crypto.c
> index 83572b827..ca595b0a5 100644
> --- a/tests/unit_tests/openvpn/test_crypto.c
> +++
Hi,
> +if (dco_get_overlapped_result(handle, ov, ,
> poll_interval_ms, FALSE) != 0)
With the removal of mingw compat patch ("dco-win: implement
GetOverlappedResultEx for mingw32"), this needs to be changed to
GetOverlappedResultEx (signature is the same).
-Lev
Am 24.06.22 um 10:37 schrieb Antonio Quartulli:
Signed-off-by: Antonio Quartulli
A lot of the code is still my code so my review not really valid for
those parts but I think Antonio has check this code.
Acked-By: Arne Schwabe
___
Am 24.06.22 um 10:37 schrieb Antonio Quartulli:
Signed-off-by: Antonio Quartulli
---
src/openvpn/options.h | 20
src/openvpn/tun.h | 1 +
2 files changed, 21 insertions(+)
Acked-By: Arne Schwabe
___
Openvpn-devel
Am 24.06.22 um 10:37 schrieb Antonio Quartulli:
+int ret = open_tun_dco(tt, ctx, dynamic_name);
+if (ret == -EEXIST)
+{
+msg(M_INFO, "TUN/TAP device %s exists previously, keep at
program end",
+
Am 24.06.22 um 10:37 schrieb Antonio Quartulli:
Signed-off-by: Antonio Quartulli
---
src/openvpn/init.c | 49
src/openvpn/ssl_common.h | 23 +++
2 files changed, 63 insertions(+), 9 deletions(-)
Acked-By: Arne Schwabe
Am 24.06.22 um 10:37 schrieb Antonio Quartulli:
When using DCO iroutes and routes all live in the same routing table,
However, the latter should always come after the former.
for this reason assign a default metric of 200 to routes. iroutes will
later get a metric of 100.
Can you also add
Hi,
On 27/06/2022 13:09, Arne Schwabe wrote:
Am 24.06.22 um 10:37 schrieb Antonio Quartulli:
+ int ret = open_tun_dco(tt, ctx, dynamic_name);
+ if (ret == -EEXIST)
+ {
+ msg(M_INFO, "TUN/TAP device %s exists previously,
keep at
Am 24.06.22 um 10:37 schrieb Antonio Quartulli:
Signed-off-by: Antonio Quartulli
---
We will probably find a bit more odd options that needed to be added
here but don't let the perfect stand in the way of the good.
Acked-By: Arne Schwabe
___
- Fix various formatting inconsistencies
- Remove outdated (as of 2.6) information from
--data-ciphers and instead add a link to
cipher negotiation chapter.
- Some drive-by fixes in related code comments
and log messages as I was reading them.
Cc: Arne Schwabe
Signed-off-by: Frank
Acked-By: Frank Lichtenheld
Code definitely looks like it will be doing what it is
intended to do.
Would be a good opportunity for a UT, though.
On Fri, May 27, 2022 at 03:24:57AM +0200, Heiko Hund wrote:
> Override DNS related foreign_options with values set by the --dns
> option. This is
Hi,
The problem this patch solves appeared on mingw-w64 for 32bit version
6.0.0, which is the latest version of mingw on Windows. When this
patch was written (April 2021), we still used travis/appveyor which
did mingw builds on Windows so back then patch made sense.
Since we moved to GHa since
Am 24.06.22 um 10:37 schrieb Antonio Quartulli:
Signed-off-by: Antonio Quartulli
---
src/openvpn/options.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 9a0634a5..7b450296 100644
---
Am 24.06.22 um 10:37 schrieb Antonio Quartulli:
Signed-off-by: Antonio Quartulli
---
src/openvpn/networking_sitnl.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/openvpn/networking_sitnl.c b/src/openvpn/networking_sitnl.c
index bffcb067..0944ad0a 100644
---
Am 24.06.22 um 10:37 schrieb Antonio Quartulli:
+/**
+ * Install the key material in DCO for the specified peer, at the specified
slot
+ *
+ * @param multi the TLS context of the current instance
+ * @param ksthe state of the key being installed
+ * @param key2 the container
Hi,
On 27/06/2022 12:30, Lev Stipakov wrote:
Hi,
The problem this patch solves appeared on mingw-w64 for 32bit version
6.0.0, which is the latest version of mingw on Windows. When this
patch was written (April 2021), we still used travis/appveyor which
did mingw builds on Windows so back then
On 17/02/2022 19:22, Arne Schwabe wrote:
The problematic behaviour happens when start a profile without
That sentence can be improved slightly; can be done commit time. I propose:
The problematic behaviour happens when a profile is started without
auth-user-pass and connect to a server
On Mittwoch, 23. Mai 2018 21:28:02 CEST Antonio Quartulli wrote:
> -if (o && o->push_list.head && o->iroutes)
> +if (o && o->push_list.head && (o->iroutes || o->iroutes_ipv6))
[...]
> +else if (p[0] && !strcmp(p[0], "route-ipv6") && !p[2])
I think it would make sense to
18 matches
Mail list logo
