Re: [Openvpn-devel] [PATCH] FreeBSD 12.x workaround for IPv6 ifconfig is needed on 12.4 as well

2023-03-08 Thread Arne Schwabe
Am 06.03.23 um 09:07 schrieb Gert Doering: Commit 16d7f2cd4d90 tried to remove an FreeBSD 12.x ifconfig inet6 workaround based on the understanding that the upstream fix for bug 248172 went into 12.4, but that was a misread of the code - 12.4 needs the workaround as well, fixed in 13.0. Also

Re: [Openvpn-devel] [PATCH] Avoid warning about missing braces when initialising key struct

2023-03-08 Thread Arne Schwabe
Am 08.03.23 um 11:03 schrieb Antonio Quartulli: Hi, On 08/03/2023 00:57, Arne Schwabe wrote: This avoids the warning from gcc about initialising the key2 struct Change-Id: Ia73d24923b1efd99263f33ce13d90e04b59bd980 Signed-off-by: Arne Schwabe ---   src/openvpn/tls_crypt.c | 3 ++-   1 file

[Openvpn-devel] [PATCH v2] Avoid warning about missing braces when initialising key struct

2023-03-08 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli --- As concluded on IRC, this version does what we want it to do. We also quickly tested with some sample program to make sure we weren't making this up. src/openvpn/tls_crypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Openvpn-devel] [PATCH applied] Re: FreeBSD 12.x workaround for IPv6 ifconfig is needed on 12.4 as well

2023-03-08 Thread Gert Doering
Patch has been applied to the master and release/2.6 branch. commit 549fbd83f9d445863cc62b3a658a406afacdaeac (master) commit b48298ac510abd000f65fe935a2d1cf7c25ecbf3 (release/2.6) Author: Gert Doering Date: Mon Mar 6 09:07:44 2023 +0100 FreeBSD 12.x workaround for IPv6 ifconfig is needed

Re: [Openvpn-devel] [PATCH] Avoid warning about missing braces when initialising key struct

2023-03-08 Thread Antonio Quartulli
Hi, On 08/03/2023 00:57, Arne Schwabe wrote: This avoids the warning from gcc about initialising the key2 struct Change-Id: Ia73d24923b1efd99263f33ce13d90e04b59bd980 Signed-off-by: Arne Schwabe --- src/openvpn/tls_crypt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Openvpn-devel] [PATCH] tests/unit_tests: Fix 'make distcheck' with subdir-objects enabled

2023-03-08 Thread Frank Lichtenheld
Commit 7f72abcf8a56bb35a510a3409e03a4e2aaba50da enabled subdir-objects when using automake 1.16+. There is an issue with the handling of .deps directories with this option. While automake 1.16 fixed subdir-objects to work at all when _SOURCES contains "unexpanded references" and it did fix

Re: [Openvpn-devel] [PATCH applied] Re: Conditionally add subdir-objects option to automake

2023-03-08 Thread Frank Lichtenheld
On Wed, Mar 08, 2023 at 03:40:42PM +0100, Gert Doering wrote: > Not sure what to do about it... for now we've decided to move onwards > with the 2.6.1 release, as the "make dist" built tarball passes all > the tests - including "out of tree" builds - so it's not crucially > urgent ("yesterday"

Re: [Openvpn-devel] [PATCH applied] Re: Conditionally add subdir-objects option to automake

2023-03-08 Thread Gert Doering
Hi, On Fri, Feb 10, 2023 at 07:59:03PM +0100, Gert Doering wrote: > This warning has been quite an annoyance for some time - thanks for > taking care of it, and also figuring out what caveats apply. I do > not understand autoconf intricacies, but I have fed this to github and > to the buildbots,

[Openvpn-devel] [PATCH] Set netlink socket to be non-blocking

2023-03-08 Thread Arne Schwabe
Even though we use select/poll to explicitly query when the nextlink socket is ready for read, sometimes we end up reading from the socket when it is not ready to read and then the process hangs for several seoneds (20-30s). Avoid this situation by setting the socket to be non-blocking, so we get

[Openvpn-devel] [PATCH applied] Re: Avoid warning about missing braces when initialising key struct

2023-03-08 Thread Gert Doering
Acked-by: Gert Doering Confirmed that it pacifies github, and tests still pass. Your patch has been applied to the master and release/2.6 branch. commit 5a14a5ea572ec88e2a9e7bfdad9d5fe31025c021 (master) commit 26417824ff81ba1dd18b03a40822da533018a892 (release/2.6) Author: Antonio Quartulli

Re: [Openvpn-devel] [PATCH] tests/unit_tests: Fix 'make distcheck' with subdir-objects enabled

2023-03-08 Thread Selva Nair
Hi, On Wed, Mar 8, 2023 at 10:08 AM Frank Lichtenheld wrote: > Commit 7f72abcf8a56bb35a510a3409e03a4e2aaba50da enabled subdir-objects > when using automake 1.16+. > > There is an issue with the handling of .deps directories with this option. > While automake 1.16 fixed subdir-objects to work at

Re: [Openvpn-devel] [PATCH] Set netlink socket to be non-blocking

2023-03-08 Thread Antonio Quartulli
Hi, On 08/03/2023 16:19, Arne Schwabe wrote: Even though we use select/poll to explicitly query when the nextlink nextlink -> netlink socket is ready for read, sometimes we end up reading from the socket when it is not ready to read and then the process hangs for several seoneds (20-30s).

[Openvpn-devel] [PATCH] dco: don't use NetLink to exchange control packets

2023-03-08 Thread Antonio Quartulli
Using NetLink has proved to be overkill and performance critical. The amount of control traffic can also easily overrun the NetLink buffer when a server has enough clients connected. Stop using NetLink to send/receive control packets and just use the transport socket as if DCO was not there at

[Openvpn-devel] [PATCH] dco: print version to log if available

2023-03-08 Thread Antonio Quartulli
In order to provide better support in case of troubleshooting issues, it's important to know what exact DCO version is loaded on the user system. Therefore print the DCO version during bootup. For Windows and FreeBSD we currently implement a placeholder printing 'v0'. This should be improved