Am 17.05.23 um 22:47 schrieb Antonio Quartulli:
Hi,
On 17/05/2023 22:01, Ilya Shipitsin wrote:
malloc was not checked against NULL, I was able
to get core dump in case of failure
Signed-off-by: Ilya Shipitsin
---
src/openvpn/dco_freebsd.c | 5 +
1 file changed, 5 insertions(+)
diff --
Hi,
On Thu, May 18, 2023 at 09:00:26AM +0200, Matthias Andree wrote:
> That, and constants usually go on the left-hand side of comparison so
> the compiler flags the accidental if (foo = NULL) even if it does not
> produce "add a pair of parentheses if you really mean to use an
> assignment as if(
чт, 18 мая 2023 г. в 08:47, Gert Doering :
> Hi,
>
> On Wed, May 17, 2023 at 04:43:01PM -0400, Kristof Provost wrote:
> > Fwiw: I usually don???t bother handling malloc failure in userspace,
> > because modern systems all overallocate anyway, so the first thing
> > you know about lack of memory is
чт, 18 мая 2023 г. в 09:10, Илья Шипицин :
>
>
> чт, 18 мая 2023 г. в 08:47, Gert Doering :
>
>> Hi,
>>
>> On Wed, May 17, 2023 at 04:43:01PM -0400, Kristof Provost wrote:
>> > Fwiw: I usually don???t bother handling malloc failure in userspace,
>> > because modern systems all overallocate anyway,
Am 18.05.23 um 09:09 schrieb Gert Doering:
Hi,
On Thu, May 18, 2023 at 09:00:26AM +0200, Matthias Andree wrote:
That, and constants usually go on the left-hand side of comparison so
the compiler flags the accidental if (foo = NULL) even if it does not
produce "add a pair of parentheses if you r
From: Lev Stipakov
With --dev-node on Windows, one can specify GUID
of the adapter openvpn should use. Those can be listed with:
C:\Program Files\OpenVPN\bin>openvpn.exe --show-adapters
While on it, remove "TAP-WIN32 / Wintun" from --show-adapters output.
Fixes https://github.com/OpenVPN/ope
From: Lev Stipakov
At the moment if --name is not specified, adapter names
are generated by Windows and they look a bit confusing
like "Local Area Connection 2".
This is also behavior of "Add a new virtual network
adapter" shortcuts.
This makes tapctl generate driver-specific names for adapter
From: Lev Stipakov
At the moment if --name is not specified, adapter names
are generated by Windows and they look a bit confusing
like "Local Area Connection 2".
This is also behavior of "Add a new virtual network
adapter" shortcuts.
This makes tapctl generate driver-specific names for adapter
From: Selva Nair
Setting the desktop as "winsta0\default" does not always work when run
from a non-interactive session which may not have access to the
the window station "Winsta0". Leave this as NULL to let the system
automatically assign a window station and desktop.
Test runs on Win10 confirm
Hi,
On Thu, May 18, 2023 at 12:25 PM Lev Stipakov wrote:
> From: Lev Stipakov
>
> At the moment if --name is not specified, adapter names
> are generated by Windows and they look a bit confusing
> like "Local Area Connection 2".
>
> This is also behavior of "Add a new virtual network
> adapter
malloc was not checked against NULL, I was able
to get core dump in case of failure
Signed-off-by: Ilya Shipitsin
---
v2:
- style correction
src/openvpn/dco_freebsd.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/openvpn/dco_freebsd.c b/src/openvpn/dco_freebsd.c
index abeb..a
Acked-by: Gert Doering
As discussed.
Tested with a basic client run on FreeBSD14 with DCO.
Your patch has been applied to the master and release/2.6 branch.
commit 5e79aed439d4e1b101c768aabfd695cd1c0a54ce (master)
commit 73ce6ac984e3ab496f97979e41f2a27569a432fd (release/2.6)
Author: Ilya Shipi
Acked-by: Gert Doering
The patch is actually quite trivial - just prevent the "if (dco)"
option checker from unsetting --dev-node...
I have not tested it beyond "stare-at-code" and "do a MinGW test compile".
Your patch has been applied to the master and release/2.6 branch.
commit c543cf464e978
13 matches
Mail list logo
