Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/469?usp=email )
Change subject: Use mingw compile definition also to unit tests
..
Patch
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/481?usp=email )
Change subject: Move get_tmp_dir to win32-util.c and error out on failure
From: Arne Schwabe
Currently we only warn in get_tmp_dir fails and set o->tmp_dir to
a null pointer. This will not be caught by check_file_access_chroot
either since that ignores NULL pointers but other parts of OpenVPN
will assume that tmp_dir is set to a non-NULL string.
Also move get_tmp_dir
Mildly tested (GHA build).
Fixed "ssl-utils.c -> win32-util.c" in the commit message.
Your patch has been applied to the master branch.
commit f0a17ed8513405af0efb1df2ab2bda3956e01910
Author: Arne Schwabe
Date: Mon Jan 8 18:13:49 2024 +0100
Move get_tmp_dir to win32-util.c and error out
cron2 has uploaded a new patch set (#3) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/481?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by cron2, Code-Review+2 by flichtenheld
Change subject: Move get_tmp_dir to win32-u
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/481?usp=email )
Change subject: Move get_tmp_dir to win32-util.c and error out on failure
..
Move get_tmp_dir to win32-util.c and error out on failure
Cur
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/489?usp=email
to review the following change.
Change subject: Windows: enforce 'block-local' with WFP filters
Attention is currently required from: d12fk, flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/489?usp=email )
Change subject: Windows: enforce 'block-local' with WFP filters
