Attention is currently required from: flichtenheld, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1110?usp=email )
Change subject: Introduce msglvl_t to unify msglevel type handling
...
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1197?usp=email
to look at the new patch set (#2).
Change subject: add building of openvpnsrvmsg.dll from eve
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1197?usp=email
to review the following change.
Change subject: add building of openvpnsrvmsg.dll from eventmsg
Attention is currently required from: plaisthos, stipa.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1199?usp=email )
Change subject: GHA: collect more artifacts for mingw builds
..
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1200?usp=email
to review the following change.
Change subject: GHA: collect more artifacts for mingw builds
..
Attention is currently required from: cron2, flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1197?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were remove
From: Lev Stipakov
Starting from commit
d383d6e ("win: replace wmic invocation with powershell")
we pass --dhcp-option DOMAIN value to a powershell command
to set DNS domain. Without validation this opens the door
to a command injection atack.
This only allows domain names with chartacters:
Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1198?usp=email )
Change subject: Validate DNS domain name before powershell invocation
.
Attention is currently required from: cron2, flichtenheld, plaisthos.
Hello flichtenheld, plaisthos, stipa,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1197?usp=email
to look at the new patch set (#4).
Change subject: fix building of openvpnsrvms
W dniu 9/16/25 o 12:43, Sabrina Dubroca pisze:
> 2025-09-09, 16:43:01 +0200, Marek Mietus wrote:
>> W dniu 9/9/25 o 13:17, Antonio Quartulli pisze:
>>> On 09/09/2025 07:43, Marek Mietus wrote:
Currently, all xmit flows use dst_cache in a way that references
its dst_entry for each xmitted
Attention is currently required from: cron2, flichtenheld, plaisthos.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1197?usp=email )
Change subject: fix building of openvpnsrvmsg.dll from eventmsg.mc in mingw
builds
...
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1194?usp=email )
Change subject: ps: Fix conversion warnings related to send/recv return values
..
W dniu 9/16/25 o 12:49, Sabrina Dubroca pisze:
> 2025-09-12, 13:24:20 +0200, Marek Mietus wrote:
>> ovpn_udp4_output unnecessarily references the dst_entry from the
>> dst_cache.
>
> This should probably include a description of why it's safe to skip
> the reference in this context.
>
Noted, wil
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email )
Change subject: openvpnserv: Fix writing messages to the event log
..
Patch Set 3:
(1 comment)
Patchset:
PS2:
> That's the PO
Attention is currently required from: flichtenheld, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1110?usp=email )
Change subject: Introduce msglvl_t to unify msglevel type handling
...
Attention is currently required from: cron2, plaisthos, stipa.
selvanair has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1197?usp=email )
Change subject: fix building of openvpnsrvmsg.dll from eventmsg.mc in mingw
builds
..
W dniu 9/9/25 o 13:17, Antonio Quartulli pisze:
> On 09/09/2025 07:43, Marek Mietus wrote:
>> Currently, all xmit flows use dst_cache in a way that references
>> its dst_entry for each xmitted packet. These atomic operations
>> are redundant in some flows.
>
> Can you elaborate on the current limi
Attention is currently required from: plaisthos, stipa.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1200?usp=email )
Change subject: GHA: collect more artifacts for mingw builds
..
From: Lev Stipakov
Collect also binaries for openvpnserv, tapctl and openvpnmsica.
Change-Id: Iaebc46f9156657128dc52c979202545be8865656
Signed-off-by: Lev Stipakov
Acked-by: Frank Lichtenheld
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1200
---
This change was reviewed on Gerrit and ap
Attention is currently required from: cron2, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1197?usp=email )
Change subject: fix building of openvpnsrvmsg.dll from eventmsg.mc in mingw
builds
..
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1199?usp=email
to review the following change.
Change subject: GHA: collect more artifacts for mingw builds
..
Attention is currently required from: cron2, flichtenheld, plaisthos.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1197?usp=email )
Change subject: fix building of openvpnsrvmsg.dll from eventmsg.mc in mingw
builds
...
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1194?usp=email )
Change subject: ps: Fix conversion warnings related to send/recv return values
..
Attention is currently required from: ordex, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1110?usp=email )
Change subject: Introduce msglvl_t to unify msglevel type handling
...
Attention is currently required from: cron2, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1197?usp=email )
Change subject: add building of openvpnsrvmsg.dll from eventmsg.mc to
autoconf/mingw builds
.
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1198?usp=email
to review the following change.
Change subject: Validate DNS domain name before powershell invo
selvanair has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email )
Change subject: openvpnserv: Fix writing messages to the event log
..
Patch Set 3:
(1 comment)
Patchset:
PS2:
> Line #336
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1183?usp=email
to review the following change.
Change subject: win: replace wmic invocation with powershell
..
Attention is currently required from: d12fk, flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1191?usp=email )
Change subject: Allow route_ipv6_match_host to be used outside of route.c
Attention is currently required from: plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1197?usp=email )
Change subject: fix building of openvpnsrvmsg.dll from eventmsg.mc in mingw
builds
.
stipa has abandoned this change. (
http://gerrit.openvpn.net/c/openvpn/+/1199?usp=email )
Change subject: GHA: collect more artifacts for mingw builds
..
Abandoned
The master patch applies for 2.6, no need for a separate one.
Attention is currently required from: flichtenheld, plaisthos, stipa.
selvanair has removed a vote from this change. (
http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email )
Change subject: openvpnserv: Fix writing messages to the event log
..
32 matches
Mail list logo