Samuli Seppänen wrote:
> here's the next version of the patch;
Functionally fine!
> def main(config):
> +
> +# Do a signed build by default
> +unsignedBuild=False
Maybe name the option signedBuild instead? :)
> +# Check if the SignTool module is present. This avoids ImportErrors
>> I agree that there should be no way one could make an unsigned build by
>> mistake. I think dazo's suggestion about having a command-line switch
>> ("force unsigned build") is a good one. The SIGNTOOL variable could then
>> be used to just locate signtool.exe and nothing else. This would make